Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update project profile 5809 #6164

Merged
merged 5 commits into from
Jan 26, 2024

Conversation

jtw007
Copy link
Member

@jtw007 jtw007 commented Jan 25, 2024

Fixes #5809

What changes did you make?

  • updated partners variable to include Atwater Village

Why did you make the changes (we will use this info to test)?

  • to keep information up-to-date

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

Screen Shot 2024-01-25 at 14 30 51

Screen Shot 2024-01-25 at 14 31 03

Visuals after changes are applied

Screen Shot 2024-01-25 at 14 31 33
Screen Shot 2024-01-25 at 14 31 41

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b jtw007-update-project-profile-5809 gh-pages
git pull https://github.com/jtw007/website.git update-project-profile-5809

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/jtw007/website/blob/update-project-profile-5809/CONTRIBUTING.md  

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours labels Jan 25, 2024
@iancooperman iancooperman self-requested a review January 26, 2024 02:03
@iancooperman
Copy link
Member

ETA: EoD 1/25/2024
Availability: 1/25 - After 8pm

@iancooperman

This comment was marked as duplicate.

Copy link
Member

@iancooperman iancooperman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following check out:

  • Correctly linked issue and branch.
  • Atwater Village added to partners variable.
  • Changes are reflected in the browser and in different viewports.
  • No extraneous changes.

Great job, @jtw007! I approve.

@heejung-hong heejung-hong self-requested a review January 26, 2024 06:26
Copy link
Member

@heejung-hong heejung-hong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!
The branches are correct and the issue is linked.
The correct file was changed with the correct information.
I have inspected and confirmed the changes in developer mode on Chrome (desktop, iPad, and iPhone view), Firefox, and Safari browser.

@jphamtv jphamtv merged commit 6dbac8c into hackforla:gh-pages Jan 26, 2024
12 checks passed
@jphamtv
Copy link
Member

jphamtv commented Jan 26, 2024

Nice work, @jtw007. Just a reminder to complete the remaining action items in the issue, now that the PR is merged. Thanks!

@jtw007 jtw007 deleted the update-project-profile-5809 branch January 26, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Project Profile: Lucky Parking (Add Partner: Atwater Village)
4 participants