-
-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented SRI check on the external babel links #6152
Implemented SRI check on the external babel links #6152
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:
|
ETA: EoD 1/25/12 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @nelsonuprety1 thanks for taking up this issue, these are my observations:
- the to/from branch is correct
- the linked issue is correct as well
- the issue correctly states the changes made and the reason to make those changes
- both the attributes
integrity
andcrossorigin
are added and with a correctsha-hash
- on manual testing there's no error generated in the
browser-console
- also the babel.js gets loaded correctly, thanks for providing the screenshot of pages using the file
default-markdown.html
anddefault.html
I noticed you wanted to do default.html
instead of 'default.html' (you need to use backticks the key on top of tab
)
PR approved !!!
@roslynwythe please check the PR thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @nelsonuprety1 for completing this issue which improves the security of our website. The branches are setup correctly, your code changes are correct and clean, and you described your work. Great job!
Fixes #6120
What changes did you make?
default-markdown.html
anddefault.html
files was updated with integrity and crossorigin attributes.Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied