-
-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Communities of Practice: Engineering - removed Alejandro Gomez #6081
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:
|
Availability: tomorrow evening, Saturday evening, Sunday afternoon |
Hi @mademarc! Thanks for volunteering to review this issue! When you have a minute, please add your ETA and Availability. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jtw007 Branches aren't correctly set. You need to create a specific branch on your fork.
You can see the necessary documentation just here.
Just an advice for you next PR, you can improve the clarity of the body:
- Say why you did this change, in you case: To keep project information up to date
- Add screenshots before/after of the website view, not of the code. The goal is to have a visual rendering of your work.
Feel free to contact me on slack if you have any questions 👍
Review ETA: 01/12/2024 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
closing this PR, created new branch on my fork and created a new pull request here: #6103 |
Fixes #6074
What changes did you make?
-removed Alejandro Gomez from yml file
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied