Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Html refactor 2fa #5709 #6076

Merged
merged 2 commits into from
Jan 10, 2024

Conversation

coding-yost
Copy link
Member

@coding-yost coding-yost commented Jan 8, 2024

Fixes #5709

What changes did you make?

  • Change to line 29 of guide-pages/2fa from single quote to double quotes

Why did you make the changes (we will use this info to test)?

  • support linter for HTML

visual change

  • No visual change.

Copy link

github-actions bot commented Jan 8, 2024

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b coding-yost-HTML-refactor-2fa-#5709 gh-pages
git pull https://github.com/coding-yost/website.git HTML-refactor-2fa-#5709

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/coding-yost/website/blob/HTML-refactor-2fa-#5709/CONTRIBUTING.md  

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Feature: Refactor HTML size: 0.25pt Can be done in 0.5 to 1.5 hours labels Jan 8, 2024
@kwangric kwangric self-requested a review January 8, 2024 21:30
Copy link
Member

@kwangric kwangric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Branches are set up correctly. The PR is linked to the corresponding issue and the requested change has been made. Great work!

@freaky4wrld freaky4wrld self-requested a review January 9, 2024 07:04
@freaky4wrld
Copy link
Member

ETA: EOD 1/9/24

@freaky4wrld
Copy link
Member

@coding-yost please provide the after/before screenshots as per the templates. Ping me when you are done and I'll approve it.

@coding-yost
Copy link
Member Author

@coding-yost please provide the after/before screenshots as per the templates. Ping me when you are done and I'll approve it.

The changes made did not contribute to any visual changes on the website so I did not think before/after screen shots were required as they ask to not screenshot code.

Copy link
Member

@freaky4wrld freaky4wrld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are made accordingly, the to/from branch is great, everything looks great, @coding-yost thanks for mentioning that no changes needed... PR approved

@t-will-gillis t-will-gillis merged commit ee24c3f into hackforla:gh-pages Jan 10, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Refactor HTML good first issue Good for newcomers role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor HTML to resolve linter error: _guidepages/2FA.html - line 29
4 participants