-
-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Html refactor 2fa #5709 #6076
Html refactor 2fa #5709 #6076
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Branches are set up correctly. The PR is linked to the corresponding issue and the requested change has been made. Great work!
ETA: EOD 1/9/24 |
@coding-yost please provide the after/before screenshots as per the templates. Ping me when you are done and I'll approve it. |
The changes made did not contribute to any visual changes on the website so I did not think before/after screen shots were required as they ask to not screenshot code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes are made accordingly, the to/from branch is great, everything looks great, @coding-yost thanks for mentioning that no changes needed
... PR approved
Fixes #5709
What changes did you make?
Why did you make the changes (we will use this info to test)?
visual change