Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed reference to CFA in Privacy Policy Intro #6073

Merged

Conversation

iancooperman
Copy link
Member

Fixes #5958

What changes did you make?

  • Replaced CFA reference in privacy policy intro with reference to Civic Tech Structure, Inc.

Why did you make the changes (we will use this info to test)?

  • HfLA is no longer part of CfA.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

image

Visuals after changes are applied

image

Copy link

github-actions bot commented Jan 7, 2024

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b iancooperman-privacy-policy-cfa-removal-5958 gh-pages
git pull https://github.com/iancooperman/website.git privacy-policy-cfa-removal-5958

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/iancooperman/website/blob/privacy-policy-cfa-removal-5958/CONTRIBUTING.md  

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers time sensitive Needs to be worked on by a particular timeframe P-Feature: Privacy Policy https://www.hackforla.org/privacy-policy size: 0.25pt Can be done in 0.5 to 1.5 hours labels Jan 7, 2024
@robertnjenga robertnjenga self-requested a review January 7, 2024 19:30
@robertnjenga
Copy link
Member

Review ETA: 01/07/2024
Availability: 10am - 2pm

Copy link
Member

@robertnjenga robertnjenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @iancooperman Great Job!
You linked the original issue, branches are set up correctly, descriptions of changes you made and why the changes were needed i.e remove mention of Code for America from the Privacy Policy, and appropriate screenshots of before and after.
I am able to confirm in Docker that changes appear correctly. Thanks for working on this issue.

@kwangric kwangric self-requested a review January 8, 2024 21:41
Copy link
Member

@kwangric kwangric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Branches are set up correctly. The PR is linked to the corresponding issue and the requested change to the Privacy Policy page been made.

Screenshots of the changes were included and everything looks good in Docker. Great work!

@kwangric kwangric merged commit 7865c81 into hackforla:gh-pages Jan 8, 2024
10 checks passed
jtw007 pushed a commit to jtw007/website that referenced this pull request Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Privacy Policy https://www.hackforla.org/privacy-policy role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Code for America from Privacy Policy intro
3 participants