Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated wiki link for bop - #5972 #6061

Merged

Conversation

siddhanthiyer-99
Copy link
Member

@siddhanthiyer-99 siddhanthiyer-99 commented Jan 4, 2024

Fixes #5972

What changes did you make?

Changed the link of the wiki URL for Brigade Organizers Playbook.

Why did you make the changes (we will use this info to test)?

Old code had codeforamerica in the link, the new one doesn't.

No visual changes.

Copy link

github-actions bot commented Jan 4, 2024

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b siddhanthiyer-99-update-wiki-link-5972 gh-pages
git pull https://github.com/siddhanthiyer-99/website.git update-wiki-link-5972

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/siddhanthiyer-99/website/blob/update-wiki-link-5972/CONTRIBUTING.md  

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours labels Jan 4, 2024
@heejung-hong heejung-hong self-requested a review January 5, 2024 05:34
Copy link
Member

@heejung-hong heejung-hong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!
The branches are correct and the issue is linked.
The correct file was changed with the correct information.
I have inspected and confirmed the changes in developer mode on Chrome (desktop, iPad, and iPhone view), Firefox, and Safari browser.

Screenshot 2024-01-04 at 9 31 24 PM

@robertnjenga robertnjenga self-requested a review January 7, 2024 20:55
@robertnjenga
Copy link
Member

Review ETA: 01/07/2024
Availability: 10am - 2pm

Copy link
Member

@robertnjenga robertnjenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @siddhanthiyer-99! Thank you for taking up this issue.
The branching was done correctly, you used correct branch to commit from and into, you linked the issue, code changes were made correctly, description of changes i.e updated wiki link in brigade-organizers-playbook project file, and reason for the changes. I'm able to confirm on Docker that that the wiki link in the Brigade Playbook project page points to the relevant page.
Just one edit if possible in the PR comments - replace "No screenshots" with "No Visual Changes"
After the edit you can re-request the review. Thanks!

@siddhanthiyer-99
Copy link
Member Author

@robertnjenga Thanks for the feedback! I have made the necessary changes in the PR comments.

Copy link
Member

@robertnjenga robertnjenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@siddhanthiyer-99 Thanks for making the changes, Nice Work!

@t-will-gillis t-will-gillis merged commit d49e435 into hackforla:gh-pages Jan 8, 2024
11 checks passed
@siddhanthiyer-99 siddhanthiyer-99 deleted the update-wiki-link-5972 branch February 27, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update wiki url in brigade-organizers-playbook project file
4 participants