-
-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated wiki link for bop - #5972 #6061
updated wiki link for bop - #5972 #6061
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review ETA: 01/07/2024 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @siddhanthiyer-99! Thank you for taking up this issue.
The branching was done correctly, you used correct branch to commit from and into, you linked the issue, code changes were made correctly, description of changes i.e updated wiki link in brigade-organizers-playbook project file, and reason for the changes. I'm able to confirm on Docker that that the wiki link in the Brigade Playbook project page points to the relevant page.
Just one edit if possible in the PR comments - replace "No screenshots" with "No Visual Changes"
After the edit you can re-request the review. Thanks!
@robertnjenga Thanks for the feedback! I have made the necessary changes in the PR comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@siddhanthiyer-99 Thanks for making the changes, Nice Work!
Fixes #5972
What changes did you make?
Changed the link of the wiki URL for Brigade Organizers Playbook.
Why did you make the changes (we will use this info to test)?
Old code had codeforamerica in the link, the new one doesn't.
No visual changes.