Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "VRMS" to cspell.json so there aren't any false positive spellings #6012

Closed
wants to merge 1 commit into from

Conversation

ndmoc
Copy link
Member

@ndmoc ndmoc commented Dec 19, 2023

Fixes #5687

What changes did you make?

Updated cspell.json by adding a new element "VRMS" ensuring there aren't any false positives in the word "VRMS" in any codebases.

Why did you make the changes (we will use this info to test)?

To remove any false positives in any codebase with the word "VRMS"

removing screenshot option since no visible change in website and only in code

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b ndmoc-gh-pages gh-pages
git pull https://github.com/ndmoc/website.git gh-pages

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/ndmoc/website/blob/gh-pages/CONTRIBUTING.md  

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: About Us https://www.hackforla.org/about/ Feature: Infrastructure For changes on site technical architecture size: 0.25pt Can be done in 0.5 to 1.5 hours feature: spelling labels Dec 19, 2023
@james-aguirre james-aguirre self-assigned this Dec 19, 2023
@james-aguirre
Copy link
Member

james-aguirre commented Dec 19, 2023

Review ETA: 3 PM 12/19/23
Availability: 12-3 PM Tues

@pdimaano pdimaano self-requested a review December 19, 2023 18:52
@james-aguirre james-aguirre self-requested a review December 19, 2023 18:53
@james-aguirre james-aguirre removed their assignment Dec 19, 2023
Copy link
Member

@james-aguirre james-aguirre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ndmoc Thank you for taking up this issue! You were descriptive in telling us about the changes made. You correctly put a linked issue in your PR, and you updated the correct section in cspell.json. 🙌🏼 Just two small changes requested!

#1 On the PR, under the visual changes section, it seems your screenshots didn't upload correctly.

Screenshot 2023-12-19 at 11 40 53 AM

#2 Please create a new branch with a name giving a brief description of the issue. An example name could be: update-cspelljson-with-false-positive-term-VRMS, then merge that branch into the main hackforla:gh-pages branch.

Screenshot 2023-12-19 at 11 45 12 AM

@ndmoc
Copy link
Member Author

ndmoc commented Dec 19, 2023

Fixes #5687

What changes did you make?

Updated cspell.json by adding a new element "VRMS" ensuring there aren't any false positives in the word "VRMS" in any codebases.

Why did you make the changes (we will use this info to test)?

To remove any false positives in any codebase with the word "VRMS"

removing screenshot option since no visible change in website and only in code

Thank you James. I created a new branch and a pull request.

@pdimaano pdimaano removed their request for review December 19, 2023 23:52
@james-aguirre james-aguirre requested review from james-aguirre and removed request for james-aguirre December 20, 2023 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Infrastructure For changes on site technical architecture feature: spelling good first issue Good for newcomers P-Feature: About Us https://www.hackforla.org/about/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update cspell.json with false positive term 'VRMS'
2 participants