Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Section2.7.b - making sure devs checkout gh-pages first #5936

Merged

Conversation

jphamtv
Copy link
Member

@jphamtv jphamtv commented Nov 25, 2023

Fixes #5698

What changes did you make?

  • Updated the CONTRIBUTING.md file

Why did you make the changes (we will use this info to test)?

  • We need to ensure that the developer has checked out the gh-pages branch prior to proceeding to create the issue branch, and that after making files changes, the developers uses caution when using git add to prevent inclusion of unwanted files in the subsequent commit.

For Reviewers: Do not review changes locally, rather, review changes at: https://github.com/jphamtv/website/blob/update-contributing-guidelines-5698/CONTRIBUTING.md

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Updated CONTRIBUTING.md file. No visual changes to the website.

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b jphamtv-update-contributing-guidelines-5698 gh-pages
git pull https://github.com/jphamtv/website.git update-contributing-guidelines-5698

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/jphamtv/website/blob/update-contributing-guidelines-5698/CONTRIBUTING.md  

@github-actions github-actions bot added role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Feature: Wiki Complexity: Small Take this type of issues after the successful merge of your second good first issue size: 0.5pt Can be done in 3 hours or less labels Nov 25, 2023
@robertnjenga robertnjenga self-requested a review November 25, 2023 16:52
@robertnjenga
Copy link
Member

Review ETA: 11/25/2023
Availability: 10am - 5pm

Copy link
Member

@robertnjenga robertnjenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jphamtv! Great job!
The branching was done correctly, you linked the issue, you gave a description of what you did and why the changes were made, i.e update CONTRIBUTING.md 2.7.b. You also provided the test URL, which confirms the updates. Thank you for taking up this issue.

@freaky4wrld freaky4wrld self-requested a review November 26, 2023 23:22
@freaky4wrld
Copy link
Member

ETA: EOD 11/27
Availability: Evenings

Copy link
Member

@freaky4wrld freaky4wrld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there @jphamtv , all the changes mentioned in the linked issue are made and are looking perfect in your branch. The merge is going in correct branch, I approve it..... great work there

@t-will-gillis
Copy link
Member

Hey @jphamtv Thank you for working on this issue. I see that you adjusted the language on Line 554 - great work for noticing and then correcting this.

@t-will-gillis t-will-gillis merged commit 931b46a into hackforla:gh-pages Nov 27, 2023
11 checks passed
@jphamtv jphamtv deleted the update-contributing-guidelines-5698 branch November 27, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Wiki role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update CONTRIBUTING.md Section2.7.b - making sure devs checkout gh-pages first
4 participants