-
-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Section2.7.b - making sure devs checkout gh-pages first #5936
Update Section2.7.b - making sure devs checkout gh-pages first #5936
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:
|
Review ETA: 11/25/2023 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jphamtv! Great job!
The branching was done correctly, you linked the issue, you gave a description of what you did and why the changes were made, i.e update CONTRIBUTING.md 2.7.b. You also provided the test URL, which confirms the updates. Thank you for taking up this issue.
ETA: EOD 11/27 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there @jphamtv , all the changes mentioned in the linked issue are made and are looking perfect in your branch. The merge is going in correct branch, I approve it..... great work there
Hey @jphamtv Thank you for working on this issue. I see that you adjusted the language on Line 554 - great work for noticing and then correcting this. |
Fixes #5698
What changes did you make?
CONTRIBUTING.md
fileWhy did you make the changes (we will use this info to test)?
gh-pages
branch prior to proceeding to create the issue branch, and that after making files changes, the developers uses caution when usinggit add
to prevent inclusion of unwanted files in the subsequent commit.For Reviewers: Do not review changes locally, rather, review changes at: https://github.com/jphamtv/website/blob/update-contributing-guidelines-5698/CONTRIBUTING.md
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Updated CONTRIBUTING.md file. No visual changes to the website.