Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include meetingName on Project Meetings page #5906

Merged

Conversation

mshirk2
Copy link
Member

@mshirk2 mshirk2 commented Nov 14, 2023

Fixes #5345

What changes did you make?

  • Inserted meetingName on the Project Meetings page
  • Included logic to add a comma after meetingName when dsc is not an empty string

Why did you make the changes (we will use this info to test)?

  • To provide additional information about project meetings

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

Before Changes

Visuals after changes are applied

After Changes

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b mshirk2-revise-projects-meeting-page-5345 gh-pages
git pull https://github.com/mshirk2/website.git revise-projects-meeting-page-5345

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/mshirk2/website/blob/revise-projects-meeting-page-5345/CONTRIBUTING.md  

@github-actions github-actions bot added role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Complexity: Medium P-Feature: Project Meetings https://www.hackforla.org/project-meetings size: 1pt Can be done in 4-6 hours labels Nov 14, 2023
@A-Wu5
Copy link
Member

A-Wu5 commented Nov 15, 2023

Review ETA: 11 PM 11/16/2023
Availability: 5-8 PM T/Th

@freaky4wrld freaky4wrld self-requested a review November 15, 2023 03:55
@freaky4wrld
Copy link
Member

ETA: EOD 11/16/2023
Availability: Evenings

@LRenDO
Copy link
Member

LRenDO commented Nov 16, 2023

Hi @mademarc! Thanks for volunteering to review this issue! When you have a minute, please add your ETA and Availability. If for some reason you find that you're unable to review the request, please remove yourself as a reviewer. Thanks!

Copy link
Member

@freaky4wrld freaky4wrld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mshirk2 , cool work there, the PR from/to branch is correct, the correct logic is designed to achieve the required feat, the changes are correctly displayed in the visuals...... seems great for approval !!!

@mademarc
Copy link
Member

Review ETA: 11/16/2023
Availability: 7:18PM

Copy link
Member

@mademarc mademarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mshirk2 very good job on adding the if statement along with the event.meetingname on the line 45 of the js file and @LRenDO the ETA & review is done.

Copy link
Member

@A-Wu5 A-Wu5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mshirk2 Great work! The changes fufill the requirementes listed on the issue.

@t-will-gillis t-will-gillis merged commit 6471d43 into hackforla:gh-pages Nov 19, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium P-Feature: Project Meetings https://www.hackforla.org/project-meetings role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 1pt Can be done in 4-6 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revise Projects Meeting page to include more info
6 participants