-
-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added instructions for installation and use of the cspell npm packag… #5905
added instructions for installation and use of the cspell npm packag… #5905
Conversation
… to CONTRIBUTING.md
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @robertnjenga for submitting this pull request. You have setup the branches correctly, made clean updates, described your work, and provided a test URL for reviewers. I just have two requests:
- Please shorten the title of the PR. Since it is so long, it is wrapping into the body of the PR.
- Regarding the sentence "Feel free to reach out in the Hack for LA Slack channel if you have trouble installing docker on your system", I suggest making that sentence a new paragraph and changing it to ""Feel free to reach out in the Hack for LA Slack channel if you have trouble installing the VSCode extension or the cspell npm package on your system."
Review ETA: 7:30 PM 11/14/23 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@robertnjenga I left a few inline comments for minor typo fixes. Other than that, your changes look great. PR is on the correct branch and all of the links are correct. Great work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @robertnjenga. Your branches are setup correctly, the PR is descriptive, and the changes to CONTRIBUTING.md look great. I have to apologize: the "VSCode" typo was my fault entirely. Thank you for fixing it and thanks to @KyleA99 for spotting it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, nice work @robertnjenga :)
Thank You @roslynwythe and @KyleA99! |
Fixes #5652
What changes did you make?
Why did you make the changes (we will use this info to test)?
For Reviewers:
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)