-
-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed David Lam from Lucky Parking project team #5893
Removed David Lam from Lucky Parking project team #5893
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:
|
Availability: Evenings |
Availability: Evenings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jphamtv nice work there, all the needed changes are done correctly
- from/to branch is correct
- the reason for change is correct and apt
- the visuals look similar when testing on local environment
- no merging conflicts
Keep up the good work...... feel free to check on the dependencies mentioned in the issue #5803
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The branch is going into the correct branch
gh-pages
. ✅ - The original issue Update Project Profile: Lucky Parking (Remove David Lam) #5803 was properly referenced. ✅
- Per the instructions on the original issue, the specified lines of code were properly removed. ✅
- Per the provided screenshots, the visual changes are correct. ✅
Hey @jphamtv, Don't forget to mark the issue as completed on #4909 after this pull request is merged! Great work!
Fixes #5803
What changes did you make?
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied