-
-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a new Project Profile to the Expunge Assist team #5789
Added a new Project Profile to the Expunge Assist team #5789
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
Review ETA: EOD 10/28/23 |
Review ETA: EOD 10/28/23 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Chrisklangley!
Nice work on this issue! I can see that it has been handled as expected and everything looks as it should without breaking anything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR approved. Code and visuals look great. Nice work @Chrisklangley
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Chrisklangley Great job!
- Your branches from/to look good,
- you are linked back to the original issue,
- you are giving a concise description of what you did and why,
- you are providing relevant before and after screenshots,
- your code changes only what needs to be changed, and
- the new profile appears when opened in Docker with no unexpected changes.
Thanks for your work!
Fixes #5759
What changes did you make?
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied