Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a new Project Profile to the Expunge Assist team #5789

Conversation

Chrisklangley
Copy link
Contributor

Fixes #5759

What changes did you make?

  • In the _projects/expunge-assist.md file from line 41-47 I added a new profile to the leadership Variable

Why did you make the changes (we will use this info to test)?

  • Expunge Assist needed an update to their project team on the Hack For LA website

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

Screen Shot 2023-10-27 at 1 25 19 PM

Visuals after changes are applied

Screen Shot 2023-10-27 at 1 37 18 PM

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b Chrisklangley-update-expunge-assist-project-profile-5759 gh-pages
git pull https://github.com/Chrisklangley/website.git update-expunge-assist-project-profile-5759

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours labels Oct 27, 2023
@KyleA99 KyleA99 self-requested a review October 28, 2023 00:58
@KyleA99
Copy link
Member

KyleA99 commented Oct 28, 2023

Review ETA: EOD 10/28/23
Availability: 12-8 PM 10/23/23

@kezzaam kezzaam self-requested a review October 28, 2023 02:06
@kezzaam
Copy link
Member

kezzaam commented Oct 28, 2023

Review ETA: EOD 10/28/23
Availability: 27th and 28th October 7-9pm

Copy link
Member

@kezzaam kezzaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Chrisklangley!
Nice work on this issue! I can see that it has been handled as expected and everything looks as it should without breaking anything.

Copy link
Member

@KyleA99 KyleA99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR approved. Code and visuals look great. Nice work @Chrisklangley

@t-will-gillis t-will-gillis self-requested a review October 29, 2023 17:11
Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Chrisklangley Great job!

  • Your branches from/to look good,
  • you are linked back to the original issue,
  • you are giving a concise description of what you did and why,
  • you are providing relevant before and after screenshots,
  • your code changes only what needs to be changed, and
  • the new profile appears when opened in Docker with no unexpected changes.

Thanks for your work!

@t-will-gillis t-will-gillis merged commit a7c05af into hackforla:gh-pages Oct 29, 2023
10 checks passed
@Chrisklangley Chrisklangley deleted the update-expunge-assist-project-profile-5759 branch November 9, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Project Profile: Expunge Assist (Add Curtis Barber)
4 participants