-
-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new entry to leadership variable #5771
Add new entry to leadership variable #5771
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
Review ETA: 10/26/23 at 6pm (PT) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@liamtirney - Well done with this pull request!
- The new branch is merging into the correct branch 'gh-pages'
- Original issue is linked
- PR description is clear and correct
- The specified change has been correctly implemented
@liamtirney why was this closed? |
@jaasonw that was my bad, I misread the message, thought the PR had been merged, and deleted the branch from my fork. I restored the branch. Is there anything else I can do on my end to help fix this? |
Review ETA: 10/26/23 at 6pm PST. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @liamtirney
Visually everything looks really good!
• You correctly created a new branch for your issue and merged that into gh-pages
• You have a link to the issue
• I was able to clearly understand the changes you made in your PR and saw the correct changes were implemented from lines 34-40 in _projects/expunge-assist.md
great work!
Fixes #5763
What changes did you make?
_projects/expunge-assist.md
file, underleadership
variableWhy did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied