Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new entry to leadership variable #5771

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

liamtirney
Copy link
Member

Fixes #5763

What changes did you make?

  • Added new entry within _projects/expunge-assist.md file, under leadership variable

Why did you make the changes (we will use this info to test)?

  • To keep list of active HfLA project team members on the website up-to-date

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

before

Visuals after changes are applied

after

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b liamtirney-update-project-profile-5763 gh-pages
git pull https://github.com/liamtirney/website.git update-project-profile-5763

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours labels Oct 24, 2023
@mshirk2 mshirk2 self-requested a review October 24, 2023 20:55
@mshirk2
Copy link
Member

mshirk2 commented Oct 24, 2023

Review ETA: 10/26/23 at 6pm (PT)
Availability: 10-6 Weekdays

Copy link
Member

@mshirk2 mshirk2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liamtirney - Well done with this pull request!

  • The new branch is merging into the correct branch 'gh-pages'
  • Original issue is linked
  • PR description is clear and correct
  • The specified change has been correctly implemented

@liamtirney liamtirney closed this Oct 24, 2023
@liamtirney liamtirney deleted the update-project-profile-5763 branch October 24, 2023 22:31
@jaasonw
Copy link
Member

jaasonw commented Oct 25, 2023

@liamtirney why was this closed?

@liamtirney liamtirney restored the update-project-profile-5763 branch October 25, 2023 13:19
@liamtirney
Copy link
Member Author

@jaasonw that was my bad, I misread the message, thought the PR had been merged, and deleted the branch from my fork. I restored the branch. Is there anything else I can do on my end to help fix this?

@jaasonw jaasonw reopened this Oct 25, 2023
@Chrisklangley Chrisklangley self-requested a review October 25, 2023 20:23
@Chrisklangley
Copy link
Contributor

Chrisklangley commented Oct 26, 2023

Review ETA: 10/26/23 at 6pm PST.
Availability: 6-10pm Weekdays

Copy link
Contributor

@Chrisklangley Chrisklangley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @liamtirney
Visually everything looks really good!

• You correctly created a new branch for your issue and merged that into gh-pages
• You have a link to the issue
• I was able to clearly understand the changes you made in your PR and saw the correct changes were implemented from lines 34-40 in _projects/expunge-assist.md

great work!

@kwangric kwangric merged commit 87f3975 into hackforla:gh-pages Oct 26, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Project Profile: Expunge Assist (Add Samantha Hyler)
5 participants