Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated img tag in CONTRIBUTING.md #5765

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

Chrisklangley
Copy link
Contributor

Fixes #5620

What changes did you make?

  • on line 990 I removed the space and the forward slash of the img tag

Why did you make the changes (we will use this info to test)?

  • consistency for self closing tags

FOR REVIEWERS: https://github.com/chrisklangley/website/blob/img-tag-refactor-5620/CONTRIBUTING.md

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No visual changes

@Chrisklangley Chrisklangley requested a review from jaasonw October 22, 2023 19:39
@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b Chrisklangley-img-tag-refactor-5620 gh-pages
git pull https://github.com/Chrisklangley/website.git img-tag-refactor-5620

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Feature: Wiki size: 0.25pt Can be done in 0.5 to 1.5 hours labels Oct 22, 2023
Copy link
Member

@jaasonw jaasonw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good no more space and no more package-lock.json 🚀

@ajb176 ajb176 self-requested a review October 23, 2023 00:31
Copy link
Member

@ajb176 ajb176 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Changes made as requested in linked issue
  • Follows naming convention and merges into correct branch
  • No unwanted visual changes

Nice work!

As a side note, you can remove the unused bullet points by removing the dashes. You don't have to keep them just because they're in the template.

@roslynwythe roslynwythe merged commit 7f70786 into hackforla:gh-pages Oct 23, 2023
10 checks passed
@Chrisklangley Chrisklangley deleted the img-tag-refactor-5620 branch October 27, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Wiki good first issue Good for newcomers role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

img tag refactor in CONTRIBUTING.md Section 4.1 making
4 participants