-
-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SDG background bug #5740
Fix SDG background bug #5740
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
Review ETA: 10/20/2023 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jch1013! Thanks for taking up the issue.
Your branching is set up correctly, you used correct branch to commit from and into.
You linked the issue.
Code changes were made correctly as stated in the issue.
Images were included to show visual changes.
On the Lucky Parking Page, the SDG background color was applied correctly, and the view matches the live website.
Changes appear correctly on the browser on the requested pages in the issue. Great Job!
available: 10/22 9-noon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jch1013 Great work! The basics are all good: branches, link to issue, concise descriptions of what you did and why the changes were needed, and appropriate screenshots of before and after. I am able to confirm in Docker that all project pages appear to be correct in desktop, tablet, and mobile views.
Thanks for working on this issue!
Fixes #4187
What changes did you make?
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
lucky parking311-data
engage
open-community
Visuals after changes are applied(mobile views same)
lucky parking311-data
engage desktop
open community