Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SDG background bug #5740

Merged
merged 1 commit into from
Oct 22, 2023

Conversation

jch1013
Copy link
Member

@jch1013 jch1013 commented Oct 20, 2023

Fixes #4187

What changes did you make?

  • Update sdg-color-variable for 311-data, access the data, engage, and community survey projects
  • Remove old background color variable from _project_page.scss

Why did you make the changes (we will use this info to test)?

  • consistency between background and element color (wasn't matching before)
  • Note: no visual change in access the data

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied lucky parking lucky-parking-desktop-before lucky-parking-mobile-before

311-data
311-data-desktop-before
311-data-mobile-before
engage
engage-desktop-before
engage-mobile-before
open-community
open-community-desktop-before
open-community-mobile-before

Visuals after changes are applied(mobile views same) lucky parking lucky-parking-desktop-after lucky-parking-mobile-after

311-data
311-data-desktop-after
311-data-mobile-after
engage desktop
engage-desktop-after
engage-mobile-after
open community
open-community-desktop-after
open-community-mobile-after

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b jch1013-fix-SDG-background-4178 gh-pages
git pull https://github.com/jch1013/HFLA-website.git fix-SDG-background-4178

@github-actions github-actions bot added Bug Something isn't working role: front end Tasks for front end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe Complexity: Small Take this type of issues after the successful merge of your second good first issue size: 0.5pt Can be done in 3 hours or less p-feature: SDGs SDGs wherever they appear on the site (they all use a color library, set of icons, etc.) labels Oct 20, 2023
@robertnjenga robertnjenga self-requested a review October 20, 2023 16:43
@robertnjenga
Copy link
Member

Review ETA: 10/20/2023
Availability: M - F 10am - 2pm

Copy link
Member

@robertnjenga robertnjenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jch1013! Thanks for taking up the issue.
Your branching is set up correctly, you used correct branch to commit from and into.
You linked the issue.
Code changes were made correctly as stated in the issue.
Images were included to show visual changes.
On the Lucky Parking Page, the SDG background color was applied correctly, and the view matches the live website.
Changes appear correctly on the browser on the requested pages in the issue. Great Job!

@t-will-gillis t-will-gillis self-requested a review October 22, 2023 16:03
@t-will-gillis
Copy link
Member

available: 10/22 9-noon
eta: 10/22 noon

Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jch1013 Great work! The basics are all good: branches, link to issue, concise descriptions of what you did and why the changes were needed, and appropriate screenshots of before and after. I am able to confirm in Docker that all project pages appear to be correct in desktop, tablet, and mobile views.

Thanks for working on this issue!

@t-will-gillis t-will-gillis merged commit 45c1398 into hackforla:gh-pages Oct 22, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Complexity: Small Take this type of issues after the successful merge of your second good first issue P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) p-feature: SDGs SDGs wherever they appear on the site (they all use a color library, set of icons, etc.) role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less time sensitive Needs to be worked on by a particular timeframe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix SDG background color on project pages so that it matches the SDG icons
3 participants