resolve linter error in about-card-platform.html #5731
Conversation
github-actions
bot
added
good first issue
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Availability: Weekday evenings |
|
Availability: Evenings |
There was a problem hiding this comment.
Hi @jaasonw,
You correctly stated why you made the changes, what changes were made, and linked the correct issue. You added the ending span tag in the correct position and I can confirm that no visual changes were made and that everything runs fine in my local environment.
However, It does appear that your code formatter changed the double quotes on line 1 to single quotes. Everything else looks great! If you can change the double quotes back then everything will be good to go. You can re-request my review and I will approve the PR.
|
woah what the heck i did not see that, will fix |
|
Review ETA: 10/19/2023 |
There was a problem hiding this comment.
- The branch is going into the correct branch
gh-pages. ✅ - The original issue Refactor HTML: _includes/about-page/about-card-platform.html - Impact #5371 was properly referenced. ✅
- A closing span tag was properly added per original issue request. ✅
Great job @jaasonw !
|
Hey @DorianDeptuch, when you get the chance, can you leave a comment with the ETA for your review? Thanks! |
|
Availability: Weekday afternoons |
There was a problem hiding this comment.
Hey @jaasonw,
Great job on the changes! Everything looks good to me!
fixes #5371
What changes did you make?
_includes/about-page/about-card-platform.htmlWhy did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
no visual changes across all platforms (chrome, firefox, webkit, edge)