Img tag refactor 5619 #5665
Merged
Img tag refactor 5619 #5665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
github-actions
bot
added
good first issue
|
Review ETA: EOD 9/7/23 |
|
Availability: Can be reached via Slack throughout the day |
MattChau01
approved these changes
Oct 9, 2023
There was a problem hiding this comment.
- The branch is going into the correct branch
gh-pages. ✅ - The original issue img tag refactor in CONTRIBUTING.md Section 4.1 #5619 was properly referenced. ✅
- The specified line of code was properly updated per the instructions on the original issue. ✅
- You also provided a direct URL to the updated md file for review, which was very helpful! From here, I was able to verify again that the proper code was updated!
Great work @tkozek!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5619
What changes did you make?
-Removed the ending slash in the following img tag in Section 4.1:
<img src="https://user-images.githubusercontent.com/21162229/137784791-30871703-48de-4836-91ef-1268d86662a4.jpg" alt="Visual example of how to copy the comment link" />to become:
<img src="https://user-images.githubusercontent.com/21162229/137784791-30871703-48de-4836-91ef-1268d86662a4.jpg" alt="Visual example of how to copy the comment link">Why did you make the changes (we will use this info to test)?
-So that the codebase is consistent with how Hack for LA uses img HTML tags
For Reviewers: Do not review changes locally, rather, review changes at:
https://github.com/tkozek/website/blob/img-tag-refactor-5619/CONTRIBUTING.md
Screenshots of Proposed Changes Of The Website
-There are no visual changes to the site as a result of this issue.