Removed mention of CfA from the Join Us page

[YolandaHaynes]

Fixes #5447

What changes did you make?

• Removed and replaced the mention of Code for America to Civic Tech Structure.
• Updated href link to stripe donation page.
• Added clickable link on the donation image to the donation page.

Why did you make the changes (we will use this info to test)?

• To update the donation section of the join us page with current information by removing mention of CfA to Civic Tech Structure.
• Updating the donation link to a Stripe donation page and making sure the image when clicked will go to the donation page.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

Visuals after changes are applied

[github-actions]

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b YolandaHaynes-remove-CfA-join-us-page-5447 gh-pages
git pull https://github.com/YolandaHaynes/hackforlawebsite.git remove-CfA-join-us-page-5447

[pdimaano]

ETA: 10/4/23
Availability: Weekday evenings

[pdimaano]

@YolandaHaynes Good job: The branches are correct and the issue is linked. The changes are visible on my system on desktop, mobile and tablet. The correct files were changed and the links lead to the correct stripe donation page. I also see that the you changed the name for styling from "gif" to "png" since the image is now in a different format from the original. Well done!

[agutiernc]

ETA: 10/03/23
Availability: EOD

[jaasonw]

It looks good on my end with just some small accessibility nitpicks

Availability: 12pm - 6pm

[agutiernc]

The following are confirmed:

• Correct branch and linked issue
• Replaced code with the updated version
• Replaced the donation form graphic and is linked correctly
• Changes are shown in different view modes
• Confirmed before/after screenshots

You did an outstanding job @YolandaHaynes! Thanks for contributing.

As for making further changes than those listed, I'd recommend to follow the instructions and images as given.

If there are any questions or concerns, it's best to consult with the #hfla-site slack channel or a team lead. There are also more instructions on your Pre-work Checklist

[kwangric]

Hi @jaasonw & @YolandaHaynes. The accessibility findings are good points to bring up, but they are not within the scope of the issue and can be addressed in future issues. We encourage devs to follow the action items in the original issue as closely as possible. As @agutiernc brought up, any findings can be brought up on the slack channel or directly with the merge team.

[jaasonw]

LGTM then 🚀