Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Labels in Pre-work Issue Template #5634

Conversation

klei0229
Copy link
Member

@klei0229 klei0229 commented Sep 30, 2023

Fixes #5338

What changes did you make?

  • I changed the labels in the file pre-work-template--design.md to include Complexity: Prework & removed Complexity: Missing

Why did you make the changes (we will use this info to test)?

  • I made this change to switch out the label Complexity: Missing to Complexity: Prework because it is more appropriate label for this issue template (reference)

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

5338-Before

Visuals after changes are applied

5338-After-2

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b klei0229-adjust-labels-pre-work-template-5338 gh-pages
git pull https://github.com/klei0229/website.git adjust-labels-pre-work-template-5338

@github-actions github-actions bot added role: back end/devOps Tasks for back-end developers Complexity: Medium Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly size: 1pt Can be done in 4-6 hours labels Sep 30, 2023
@DorianDeptuch DorianDeptuch self-assigned this Oct 1, 2023
@DorianDeptuch
Copy link
Member

DorianDeptuch commented Oct 1, 2023

Availability: 10/1, 10/2 Afternoon/Evening
ETA: 10/2 EoD

@t-will-gillis t-will-gillis self-requested a review October 1, 2023 17:14
@DorianDeptuch DorianDeptuch removed their assignment Oct 2, 2023
@DorianDeptuch DorianDeptuch self-requested a review October 2, 2023 05:10
Copy link
Member

@DorianDeptuch DorianDeptuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @klei0229,

You have documented your changes well, you have stated why you have made the changes correctly. You also added before and after screenshots of the appropriate content. I tested creating a New issue in your branch as per the instructions, and everything works as specified.

Everything looks good to me, great job!

Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @klei0229 Awesome job- you have all the bases covered, esp. helpful are the before and after visuals. The code changes are clean and appropriate.

Thanks for your work!

@t-will-gillis t-will-gillis merged commit 39317a5 into hackforla:gh-pages Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly role: back end/devOps Tasks for back-end developers size: 1pt Can be done in 4-6 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjust the labels on Pre-work Template- Design issue template
3 participants