Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove mention CfA in about.html #5550

Merged
merged 2 commits into from
Sep 20, 2023
Merged

Remove mention CfA in about.html #5550

merged 2 commits into from
Sep 20, 2023

Conversation

YolandaHaynes
Copy link
Member

Fixes #5408

What changes did you make?

  • removed the mention of Code of America in the about.html
  • updated it to mention the Civic Tech Structure Inc.

Why did you make the changes (we will use this info to test)?

  • to update information about Hack for LA's invovlment from Code for America to Civic Tech Structure Inc.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

image
Screen Shot 2023-09-17 at 6 25 58 PM

Visuals after changes are applied

image
Screen Shot 2023-09-17 at 6 26 47 PM

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b YolandaHaynes-remove-mention-CfA-about-5408 gh-pages
git pull https://github.com/YolandaHaynes/hackforlawebsite.git remove-mention-CfA-about-5408

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: About Us https://www.hackforla.org/about/ time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours labels Sep 18, 2023
@kwangric kwangric self-requested a review September 18, 2023 14:26
@kwangric
Copy link
Member

ETA: 9/18 EOD
Availability: 2-5pm PDT

kwangric
kwangric approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@kwangric kwangric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Branches are set up correctly. The requested changes were made and everything looks good in docker. PR also includes description of the changes made and relevant screenshots. Great work!

@ortegaa32 ortegaa32 self-requested a review September 18, 2023 23:30
@ortegaa32
Copy link
Member

Review ETA: 3:00 PM 19th September 2023
Availability: 1:00 - 3:00 PM everyday

@ortegaa32
Copy link
Member

  • Branches set up correctly and PR linked to correct issue
  • Changes correctly reflected in screenshots and don't break the website
  • Changes made to the correct file and look clean

Excellent work @YolandaHaynes!

@roslynwythe roslynwythe merged commit afd3901 into hackforla:gh-pages Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ortegaa32 ortegaa32 ortegaa32 approved these changes

@kwangric kwangric kwangric approved these changes

Assignees
No one assigned
Labels
good first issue Good for newcomers P-Feature: About Us https://www.hackforla.org/about/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove mention of CfA - about.html
4 participants
@YolandaHaynes @kwangric @ortegaa32 @roslynwythe