Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Image Tag in About Page #5549

Merged

Conversation

DomenicScozz
Copy link
Member

Fixes #5189

What changes did you make?

  • The change involves using a self-closing img tag without a trailing slash.

Why did you make the changes (we will use this info to test)?

  • I implemented this alteration to enhance the uniformity of the codebase.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

I removed the ending slash from the image tag, but there were no visual changes as a result.

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b DomenicScozz-img-tag-refactor-5189 gh-pages
git pull https://github.com/DomenicScozz/website.git img-tag-refactor-5189

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Feature: Refactor HTML size: 0.25pt Can be done in 0.5 to 1.5 hours labels Sep 17, 2023
@DomenicScozz
Copy link
Member Author

Fixes #5189

What changes did you make?

  • The change involves using a self-closing img tag without a trailing slash.

Why did you make the changes (we will use this info to test)?

  • I implemented this alteration to enhance the uniformity of the codebase.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

I removed the ending slash from the image tag, but there were no visual changes as a result.

Fixes #5189

What changes did you make?

  • The change involves using a self-closing img tag without a trailing slash.

Why did you make the changes (we will use this info to test)?

  • I implemented this alteration to enhance the uniformity of the codebase.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

I removed the ending slash from the image tag, but there were no visual changes as a result.

Note: Although I only edited a single line to remove the trailing slash from the image HTML tag, my IDE, VS Code, is detecting modifications in other lines when I save the file. I've ensured that I don't have any auto-formatting enabled on save or any extensions that might be altering the file format. If you have experience with this issue, I'd greatly appreciate any advice on how to resolve it.

@DomenicScozz DomenicScozz changed the title Update Image Tag in About Page #5189 Update Image Tag in About Page Sep 17, 2023
Copy link
Member

@bphan002 bphan002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Domenic,

Thanks for looking at this issue. You edited the img tag and removed the closing slash and also removed the white space from the 2 bottom divs.

Everything looks the same after I ran your code in docker.

@LRenDO
Copy link
Member

LRenDO commented Sep 20, 2023

Hi @adrianang! Thanks for volunteering to review this issue! When you have a minute, please add your ETA and Availability. If for some reason you find that you're unable to review the request, please remove yourself as a reviewer. Thanks!

@adrianang adrianang removed their request for review September 21, 2023 22:38
@t-will-gillis t-will-gillis self-requested a review September 22, 2023 04:29
Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @DomenicScozz Great job on this issue. Your branches look good, you are linked to the original issue, your description briefly describes what you did and why, and you noted that there are no visual changes. Your code is clean and only edits what is needed.

Note: Although I only edited a single line to remove the trailing slash from the image HTML tag, my IDE, VS Code, is detecting modifications in other lines when I save the file. I've ensured that I don't have any auto-formatting enabled on save or any extensions that might be altering the file format. If you have experience with this issue, I'd greatly appreciate any advice on how to resolve it.

I can see that on lines 3 and 5, some whitespace is deleted- I think this might be what your note about is referring to? If so, this is fine.

Thanks for contributing!

@t-will-gillis t-will-gillis merged commit 21e2813 into hackforla:gh-pages Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Refactor HTML good first issue Good for newcomers role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

img Tag Refactor: _includes/about-page/about-card-donations.html - donations.svg
4 participants