Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update issue-trigger.yml #5544

Merged

Conversation

t-will-gillis
Copy link
Member

@t-will-gillis t-will-gillis commented Sep 17, 2023

Fixes #5490

What changes did you make?

  • Updated actions/checkout@v3 --> actions/checkout@v4
  • Tested to confirm the GHA functions as expected with update
  • Testing was successful- see below. OK to update

Why did you make the changes (we will use this info to test)?

  • Change made to confirm the Dependabot recommended version updates for compatibility with existing automation

Supporting files

  • Action log showing successful run of "Add-Missing-Labels-To-Issues"
  • Action log showing successful run of "Ask-For-Preliminary-Update"
  • Issue created on repo showing both comments were added

Note to PR Reviewers

  • The process for testing GHAs is different from procedures described in the CONTRIBUTING.md document. You will want to have an environment set up in your local repo and test the GHAs on the desktop.
  • First, review the following wiki pages Hack for LA's GitHub Actions and follow the "Mini Guide".
    • Pay close attention especially to Steps 6 & 7.
    • Note in Step 6: When you create your Project Board, be sure to name it (or rename it if needed) "Project Board"
    • Note in Step 7: It is best practice to give your secret an expiration date.
    • Note in Step 7 also: when you are creating your own token, do not give your token the same name that you see in the yaml file. In other words, do not give your token the same name as HfLA's token, otherwise unexpected behavior may result. Any other name is OK (for example, TEST_TOKEN).
  • To continue creating your testing environment, go to your local repo on the desktop and create a new branch for testing:
    • From your "gh-pages" branch, make sure you are synced to HfLA.
    • Select the "gh-pages" button, enter a name for your test branch (such as "test-ghas-for-pr-review"), then select "Create branch". You will make edits and test from this new branch.
    • Next, go to "Settings" on the upper right, scroll down to "Default branch", and select the button with the arrows to switch your default branch to another branch.
    • Find your newly created branch and select it, then "Update", then "I understand, update the default branch".
    • Important- when you are done testing you will want to repeat these steps to reselect "gh-pages" as your default branch and delete the test branch.
    • Now, when you make edits to the "website" on your repo you will only affect the new branch.
  • For testing this specific action you will need to make these changes to .github/workflows/issue-trigger.yml:
    • Lines 12 and 50: change to '@v4', e.g. uses: actions/checkout@v4
    • Line 30: change to reference your token, e.g. token: ${{ secrets.TEST_TOKEN }}
  • Additional steps needed to successfully test this action:
    • Set up "Labels" if you have not done so already: select "Issues" from your repo, then "New Issue", then choose any issue with "Get Started" on the right, then on the right click on the gear next to "Labels". You will need to add all of the following labels if you have not already: "Complexity: Missing", "Feature Missing", "role missing", "size: missing", "role:front end". From "Labels", click on "Edit labels" , then "New label", and add each label exactly as shown, without the quotes.
    • Now select "Issues" again, "New issue" , then at "Blank Issue Template" select "Get started".
    • If you did the previous steps correctly, four labels will be present under "Labels". Select the gear, then unselect all labels, then add "role: front end".
    • Under "Projects" select "Project Board".
    • Add any title, then "Submit new issue."
    • When the issue is created, assign yourself to the issue.
  • If the bot adds labels to the newly created issue, as well as a comment reminding your to add missing labels to the issue, then the first half of the test is successful.
  • If the bot adds a message asking you to add your Availability and ERA, then the second half of the test is successful.
  • The final confirmation will be to select the "Actions" button on your menu, and confirm the success logs (in green) for the two runs of the "Issue Trigger" gha.

Confirm Dependabot proposed updates
@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b t-will-gillis-dependabot-update-5490 gh-pages
git pull https://github.com/t-will-gillis/website.git dependabot-update-5490

@github-actions github-actions bot added role: back end/devOps Tasks for back-end developers Complexity: Medium Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms Draft Issue is still in the process of being created size: 1 pt labels Sep 17, 2023
@t-will-gillis t-will-gillis removed the Draft Issue is still in the process of being created label Sep 17, 2023
@github-actions github-actions bot added size: 1pt Can be done in 4-6 hours and removed size: 1 pt labels Sep 27, 2023
@aramattamara
Copy link
Member

Review ETA: 6 PM 9/27/23
Availability: 2 PM-6 PM Wednesday

Copy link
Member

@aramattamara aramattamara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@t-will-gillis t-will-gillis merged commit 52a1348 into hackforla:gh-pages Sep 30, 2023
12 checks passed
@t-will-gillis t-will-gillis deleted the dependabot-update-5490 branch September 30, 2023 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms role: back end/devOps Tasks for back-end developers size: 1pt Can be done in 4-6 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confirm dependabot version update to issue-trigger.yml
2 participants