Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Partner Text Under BallotNav Project #5534

Conversation

danielmshawn
Copy link
Member

Fixes #5410

What changes did you make?

  • Within _projects/ballot-nav.md, removed line "partner: Code for America, Other Brigades"
  • Replaced line with "partner: Code for San Jose, Code for Atlanta, Open Oakland"

Why did you make the changes (we will use this info to test)?

  • Simple and specific instructions from the issue

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied Screenshot 2023-09-14 at 5 53 27 PM
Visuals after changes are applied Screenshot 2023-09-14 at 6 14 33 PM

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b danielmshawn-remove-mention-of-cfa-from-ballot-nav-5410 gh-pages
git pull https://github.com/danielmshawn/website.git remove-mention-of-cfa-from-ballot-nav-5410

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours labels Sep 15, 2023
@Adastros Adastros requested a review from kezzaam September 17, 2023 17:09
@kezzaam
Copy link
Member

kezzaam commented Sep 18, 2023

Review ETA: 7:30 PM 20th September 2023
Availability: 5-6:30 PM Tues, 5-7:30pm Wed

@ortegaa32 ortegaa32 self-requested a review September 18, 2023 23:26
@ortegaa32
Copy link
Member

Review ETA: 3:00 PM 19th September 2023
Availability: 1:00-3:00 PM everyday

@kezzaam
Copy link
Member

kezzaam commented Sep 20, 2023

Hi @danielmshawn! I can confirm you've handled the changes correctly but there is another file beyond the scope of the issue that has been changed and is not mentioned in the issue's instructions. This is the github-data.jason in __data/external. So I can't approve the request until we know where these changes occurred and if they are applicable or not.

@danielmshawn
Copy link
Member Author

danielmshawn commented Sep 20, 2023

Very strange that "__data/external" was changed, as I only went into "_projects/ballot-nav.md." Perhaps something erroneously changed when I tried to sync with HackForLA's repo before making the changes? I will go to the office hours tomorrow and see if I can figure out what happened.

@LRenDO
Copy link
Member

LRenDO commented Sep 20, 2023

Hi @danielmshawn! It looks like there was a commit right around the time of yours that updated that data. If you sync up your branch to where the HFLA site is now and push it to your forked repo, it will likely resolve the problem. Feel free to ping me if you need help or have any questions!

@danielmshawn danielmshawn force-pushed the remove-mention-of-cfa-from-ballot-nav-5410 branch from 2f159e0 to 9b250cb Compare September 22, 2023 18:17
@danielmshawn
Copy link
Member Author

Hi @LRenDO, for whatever reason, I am having a difficult time getting what should be simple to work, and am stuck here. i came here to ask for help, but now it looks like this issue is closed?

If this is still open, it may be helpful to walk me through what steps to start over, as my branch is still telling me im behind in commits on the upstream, even though they should be synced.

@LRenDO
Copy link
Member

LRenDO commented Sep 23, 2023

Hi @danielmshawn! Looking at the timeline here it looks like it was inadvertently closed by you earlier. I am going to reopen it. I am happy to help. I'll DM you on Slack.

EDIT: Looks like there is nothing to potentially merge now for some reason and can't be reopned. We can work it out on slack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove mention of CfA from Ballot Nav project partners
4 participants