-
-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Partner Text Under BallotNav Project #5534
Update Partner Text Under BallotNav Project #5534
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
Review ETA: 7:30 PM 20th September 2023 |
Review ETA: 3:00 PM 19th September 2023 |
Hi @danielmshawn! I can confirm you've handled the changes correctly but there is another file beyond the scope of the issue that has been changed and is not mentioned in the issue's instructions. This is the github-data.jason in __data/external. So I can't approve the request until we know where these changes occurred and if they are applicable or not. |
Very strange that "__data/external" was changed, as I only went into "_projects/ballot-nav.md." Perhaps something erroneously changed when I tried to sync with HackForLA's repo before making the changes? I will go to the office hours tomorrow and see if I can figure out what happened. |
Hi @danielmshawn! It looks like there was a commit right around the time of yours that updated that data. If you sync up your branch to where the HFLA site is now and push it to your forked repo, it will likely resolve the problem. Feel free to ping me if you need help or have any questions! |
2f159e0
to
9b250cb
Compare
Hi @LRenDO, for whatever reason, I am having a difficult time getting what should be simple to work, and am stuck here. i came here to ask for help, but now it looks like this issue is closed? If this is still open, it may be helpful to walk me through what steps to start over, as my branch is still telling me im behind in commits on the upstream, even though they should be synced. |
Hi @danielmshawn! Looking at the timeline here it looks like it was inadvertently closed by you earlier. I am going to reopen it. I am happy to help. I'll DM you on Slack. EDIT: Looks like there is nothing to potentially merge now for some reason and can't be reopned. We can work it out on slack. |
Fixes #5410
What changes did you make?
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied