Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created initial spell check config file #5512

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

erinzz
Copy link
Member

@erinzz erinzz commented Sep 13, 2023

Fixes #5313

What changes did you make?

  • Created new cspell json file in root folder
  • Add Code Spell Check configuration to include "collabathon" as a correct word and exclude from spell check errors
  • Confirmed spell check config is in effect in _includes/about-page/about-card-sustainability.html

Why did you make the changes (we will use this info to test)?

  • Created initial Code Spell Check json file to excluded current and future desired words from spell check detections and errors

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

There are no visual changes!

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b erinzz-create-spell-check-config gh-pages
git pull https://github.com/erinzz/website.git create-spell-check-config

@github-actions github-actions bot added role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers time sensitive Needs to be worked on by a particular timeframe Feature: Onboarding/Contributing.md Complexity: Small Take this type of issues after the successful merge of your second good first issue size: 0.5pt Can be done in 3 hours or less labels Sep 13, 2023
@erinzz erinzz requested a review from roslynwythe September 13, 2023 03:50
Copy link
Member

@roslynwythe roslynwythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @erinzz adding this spell check configuration file to our repository. The branches of this Pull Request are setup correctly, the file is correct and clean, and you have described your work. Thank you for your contribution!

@ronaldpaek ronaldpaek self-requested a review September 13, 2023 21:08
Copy link
Member

@ronaldpaek ronaldpaek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@roslynwythe the spell check works for me, I added some other words to test it out as well, is this just a client side implementation for the people who have this extension installed?

@roslynwythe roslynwythe merged commit 015736e into hackforla:gh-pages Sep 14, 2023
sheehanrobb pushed a commit to sheehanrobb/website that referenced this pull request Sep 14, 2023
@erinzz erinzz deleted the create-spell-check-config branch September 22, 2023 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Onboarding/Contributing.md role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less time sensitive Needs to be worked on by a particular timeframe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create initial spell check configuration file
3 participants