#5372 #5503
#5372 #5503
Conversation
There was a problem hiding this comment.
Hi @VIDYA1980! Thank you for taking the time to work on this issue! You made clean changes to the code that match the specifications of the issue.
I noticed a couple of process things that I think need to be fixed before this pull request can be merged. First, it seems you are not assigned to the issue, #5372 . Here are the instructions on how to assign yourself to an issue, to make sure folks know that you are working on it and don't start working on it themselves: https://github.com/hackforla/website/blob/gh-pages/CONTRIBUTING.md#24a-assign--unassign-yourself-to-this-issue.
Also, the changes should be made on a branch off of your fork of gh-pages - here are the instructions for this: https://github.com/hackforla/website/blob/gh-pages/CONTRIBUTING.md#27-working-on-an-issue.
With this in mind, it might be best to close this current pull request and then submit a new one requesting to pull in the changes from this new branch you make.
Finally, do make sure you update the pull request template to describe what you did and why - here are the instructions for that: https://github.com/hackforla/website/blob/gh-pages/CONTRIBUTING.md#31b-complete-pull-request-on-hack-for-la-website-repo
Thanks again for working on this issue! I see it's your first contribution, so a special thank you and welcome!
|
@VIDYA1980 You must be a member of Hack for LA to work on our issues. If you are interested in joining please see https://www.hackforla.org/join. |
Fixes #replace_this_text_with_the_issue_number
What changes did you make?
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied