-
-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Img Tag Refactor - removed ending slash for sdg8.svg #5299
Img Tag Refactor - removed ending slash for sdg8.svg #5299
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
ETA: EOD Friday Aug 25 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pearlescence-m Great work with this pull request! The "to" and "from" branches are correct, there is a correctly formatted linked issue, your changes to the code are clean (only the slash in one ending img tag is removed) and they resulted in no visual changes (as expected).
I have one small change request for the opening comment in the pull request - can you please edit the comment to remove all the details and summary tags under the screenshots heading, and instead just put a statement that there were no visual changes? https://github.com/hackforla/website/blob/gh-pages/CONTRIBUTING.md#iv-complete-pull-request-4-include-images-if-available
After this, click the circular arrows by my icon under "reviewers" in the top right of the screen, and I'll approve the pull request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixes #5299
I am echoing @allison-truhlar 's comments above: The "to" and "from" branches are correct, there is a correctly formatted linked issue, your changes to the code are clean (only the slash in one ending img tag is removed).
I see her requested change underneath the snapshots to "No visual changes." Great Job @pearlescence-m
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for removing the display/summary tags for the visual changes in the opening comment! As I noted before, the changes to the code and the rest of the pull request format look great!
Fixes #5176
What changes did you make?
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
No visual changes.