Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete slash on img tag #5294

Merged
merged 1 commit into from
Aug 27, 2023

Conversation

shavinski
Copy link
Contributor

@shavinski shavinski commented Aug 23, 2023

Fixes #5173

What changes did you make?

  • Delete ending img tag slash

Why did you make the changes (we will use this info to test)?

  • Made the changes in order to make the codebase consistent with using the '/' in img tags

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No need for photos since there were no visual changes

Got rid of ending slash on img tag
@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b shavinski-about-page-img-tag-5173 gh-pages
git pull https://github.com/shavinski/website.git about-page-img-tag-5173

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: About Us https://www.hackforla.org/about/ Ready for Prioritization Feature: Refactor HTML size: 0.25pt Can be done in 0.5 to 1.5 hours labels Aug 23, 2023
@tesiahwang tesiahwang self-requested a review August 23, 2023 19:03
@tesiahwang
Copy link
Member

Review ETA: 8/24/2023
Availability: flexible

@Tomomi-K1 Tomomi-K1 self-requested a review August 23, 2023 20:28
@Tomomi-K1
Copy link
Member

Review ETA: 8/23/2023
Availability: 12-5pm Weekday

Copy link
Member

@Tomomi-K1 Tomomi-K1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are using correct branch, have a linked issue, slash is removed from an appropriate img tag as instructed in the linked issue and your pull request looks great. I have checked using Docker that the visual of the site remains the same.
You have done a great job!

Copy link
Member

@tesiahwang tesiahwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @shavinski - you are attempting to merge your commit into the correct base branch, are linking the corresponding issue with the proper PR formatting, and your change is applicable & clean!

Copy link
Member

@adrianang adrianang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @shavinski — the branching is set up correctly, the corresponding issue has been linked, the requested change of removing the ending slash on the image tag on only line 54 has been made, and doing so didn't seem to affect the SDG icon nor any of the other SDG icons within the card. Your PR describes the What/Why of your change clearly and also removed the excess summary and details tags, making it easy to follow.

Thank you for taking up this issue! 🙌🏼

@adrianang adrianang merged commit 8f0525a into hackforla:gh-pages Aug 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Refactor HTML good first issue Good for newcomers P-Feature: About Us https://www.hackforla.org/about/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

img Tag Refactor: _includes/about-page/about-card-sustainability.html - sdg16.svg
5 participants