-
-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete slash on img tag #5294
Delete slash on img tag #5294
Conversation
Got rid of ending slash on img tag
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
Review ETA: 8/24/2023 |
Review ETA: 8/23/2023 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are using correct branch, have a linked issue, slash is removed from an appropriate img tag as instructed in the linked issue and your pull request looks great. I have checked using Docker that the visual of the site remains the same.
You have done a great job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, @shavinski - you are attempting to merge your commit into the correct base branch, are linking the corresponding issue with the proper PR formatting, and your change is applicable & clean!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @shavinski — the branching is set up correctly, the corresponding issue has been linked, the requested change of removing the ending slash on the image tag on only line 54 has been made, and doing so didn't seem to affect the SDG icon nor any of the other SDG icons within the card. Your PR describes the What/Why of your change clearly and also removed the excess summary and details tags, making it easy to follow.
Thank you for taking up this issue! 🙌🏼
Fixes #5173
What changes did you make?
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
No need for photos since there were no visual changes