Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor img tag for sdg13 in about-card-sustainability #5249

Merged

Conversation

AudreyRose-Wooden
Copy link
Member

@AudreyRose-Wooden AudreyRose-Wooden commented Aug 18, 2023

Fixes #5174

What changes did you make?

  • removed closing slash in img HTML tag for sdg13

Why did you make the changes (we will use this info to test)?

  • refactoring img tags to maintain consistency across the codebase

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No Visual Changes

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b AudreyRose-Wooden-img-tag-refactor-5174 gh-pages
git pull https://github.com/AudreyRose-Wooden/website.git img-tag-refactor-5174

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: About Us https://www.hackforla.org/about/ Ready for Prioritization Feature: Refactor HTML size: 0.25pt Can be done in 0.5 to 1.5 hours labels Aug 18, 2023
@erinzz erinzz self-requested a review August 18, 2023 17:37
@erinzz
Copy link
Member

erinzz commented Aug 18, 2023

Availability: 8/18
ETA: 8/18 12PM

Copy link
Member

@erinzz erinzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Audrey Rose!

Great work on completing this issue! You've removed the closing slash properly and per instructed, you've also left all the other img tags untouched. You've also navigated the git workflow well by creating a new feature branch so that your origin branch can receive the changes from remote database. Good work on navigating to the about page as well since there wasn't an obvious link from the main website page. I've ran your code on my local computer, tested the about page, and looks like everything works as it should. You've submitted the pull request and included clear screenshots of the webpage. My only minor addition is to notate "No visual changes" in your submission to let your reviewers know there shouldn't be any changes between your before and after image since the issue is a refactoring of the codebase. Otherwise, everything looks great!

Erin

@ldietz08 ldietz08 self-requested a review August 18, 2023 20:49
@ldietz08
Copy link
Member

Availability: Mon-Thu 4pm-7pm
ETA: 08/21 EOD

@ronaldpaek ronaldpaek self-requested a review August 19, 2023 04:47
Copy link
Member

@ronaldpaek ronaldpaek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, good job!

@drakenguyen4000
Copy link
Member

Good job @AudreyRose-Wooden on your first issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Refactor HTML good first issue Good for newcomers P-Feature: About Us https://www.hackforla.org/about/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

img Tag Refactor: _includes/about-page/about-card-sustainability.html - sdg13.svg
6 participants