-
-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor img tag for sdg13 in about-card-sustainability #5249
Refactor img tag for sdg13 in about-card-sustainability #5249
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
Availability: 8/18 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Audrey Rose!
Great work on completing this issue! You've removed the closing slash properly and per instructed, you've also left all the other img tags untouched. You've also navigated the git workflow well by creating a new feature branch so that your origin branch can receive the changes from remote database. Good work on navigating to the about page as well since there wasn't an obvious link from the main website page. I've ran your code on my local computer, tested the about page, and looks like everything works as it should. You've submitted the pull request and included clear screenshots of the webpage. My only minor addition is to notate "No visual changes" in your submission to let your reviewers know there shouldn't be any changes between your before and after image since the issue is a refactoring of the codebase. Otherwise, everything looks great!
Erin
Availability: Mon-Thu 4pm-7pm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, good job!
Good job @AudreyRose-Wooden on your first issue. |
Fixes #5174
What changes did you make?
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
No Visual Changes