Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor engage.md tools data from string to list #5122

Merged

Conversation

a-t-klein
Copy link
Member

Fixes #4804

What changes did you make?

  • Changed tools data in engage.md from string to list

Why did you make the changes (we will use this info to test)?

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b a-t-klein-refactor-engage-tools-data-4804 gh-pages
git pull https://github.com/a-t-klein/hfla-website.git refactor-engage-tools-data-4804

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) P-Feature: Projects page https://www.hackforla.org/projects/ size: 0.25pt Can be done in 0.5 to 1.5 hours p-feature: Projects-check We use this page to check to make sure that teams are using the Technology section correctly labels Jul 31, 2023
@ldietz08 ldietz08 self-requested a review July 31, 2023 23:15
@ldietz08
Copy link
Member

Availability: Mon-Fri 4pm-7pm
ETA: 08/02 EOD

Copy link
Member

@ldietz08 ldietz08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request was done in the correct branch and you linked to the issue. As requested, the tools data was refactored from a string to a list. Well done!

@kwangric kwangric self-requested a review August 3, 2023 16:40
@kwangric
Copy link
Member

kwangric commented Aug 3, 2023

ETA: EOD 8/4
Availability: Most days after 3pm PT

Copy link
Member

@kwangric kwangric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Branches are set up correctly. The requested changes were made to the code and everything still looks good in Docker. The pull request also contains a description of what changes were made and why. Well done!

Copy link
Member

@adrianang adrianang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @a-t-klein — the branching is set up correctly, the corresponding issue is linked, the requested change has been made exactly as asked (refactor Tools into a list for Engage), and the change didn't visually or functionally affect the Engage project views for its page and card layouts when testing your branch on my local environment through Docker. The What/Why sections in your PR were also well-written.

Thanks for taking up this issue! 🙌🏼

@adrianang adrianang merged commit abd2275 into hackforla:gh-pages Aug 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) P-Feature: Projects page https://www.hackforla.org/projects/ p-feature: Projects-check We use this page to check to make sure that teams are using the Technology section correctly role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Tools data for engage.md
4 participants