-
-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update refactored tools data for public tree #4812 #5119
update refactored tools data for public tree #4812 #5119
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
Availability: 7/31 evening |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Rishav,
You documented the changes well, the tools in the markdown file are now in a list, and there are no visual updates and the site is running in my local environment. Great work!
Thanks @DorianDeptuch for the review! |
ETA: EOD 8/4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Branches are set up correctly. The requested changes were made to the code and everything still looks good in Docker. The pull request also contains a description of what changes were made and why.
For future pull request where there are no visual changes, you can remove the details tags completely and include a short message saying that there were no visual changes.
Overall, great work completing the issue!
Thank you @kwangric appreciate the merge and review! I will make sure to remove those image tags completely now and in the future. |
Fixes #4812
What changes did you make?
tools: Zeplin
totools: -Zeplin
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)