Updated meeting day on cop-engr #5003. #5112
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
github-actions
bot
added
good first issue
There was a problem hiding this comment.
Great job @MattChau01 on this Pull Request. You setup the branches correctly, your code change is clean and correct and checks out fine in the browser, and you described your work. Thank you!
|
Hey @MarkWiltberger! When you get the chance, please leave a comment with an ETA and availability for your review. Thanks! |
|
Review ETA: 2023-Aug-04-Fri 6PM |
There was a problem hiding this comment.
Nice job, @MattChau01 on the pull request. There is a linked issue. The changes are applicable. The visible changes in the screenshots and in the DEV branch browser appear to be correct. The code changes follow the ABCs: they are applicable, they do not break the main website, and they are clean. Thanks, @MattChau01!
There was a problem hiding this comment.
Hi @MattChau01 — the branching is set up correctly, the corresponding issue is linked, and the requested change of updating the meeting time for the Engineering COP has been made exactly as asked. When testing your branch on my local environment through Docker, the change is reflected on the desktop, tablet, and mobile views, and nothing else is affected. Also, your PR is well-written and well-documented!
Thank you for taking up this issue! 🙌🏼
Fixes #5003
What changes did you make?
Change:
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied