Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Tools Data for hellogov.md #5104

Conversation

evanhesketh
Copy link
Member

@evanhesketh evanhesketh commented Jul 27, 2023

Fixes #4807

What changes did you make?

  • Changed tools data in hellogov.md from a string to a list

Why did you make the changes (we will use this info to test)?

  • Tools data in .md needs to be changed from a string to a list so that the projects-check page can be refactored to include a dropdown for tools in the future

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied Project list:

4807-projects-list-before
Project detail:

4807-project-details-before
Visuals after changes are applied Project list:

4807-project-list-after
Project detail:

4807-project-details-after

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b evanhesketh-refactor-tools-data-hellogov-4807 gh-pages
git pull https://github.com/evanhesketh/website.git refactor-tools-data-hellogov-4807

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) P-Feature: Projects page https://www.hackforla.org/projects/ size: 0.25pt Can be done in 0.5 to 1.5 hours p-feature: Projects-check We use this page to check to make sure that teams are using the Technology section correctly labels Jul 27, 2023
@jch1013 jch1013 self-assigned this Jul 27, 2023
@jch1013 jch1013 self-requested a review July 27, 2023 23:08
@jch1013 jch1013 removed their assignment Jul 27, 2023
@jch1013
Copy link
Member

jch1013 commented Jul 27, 2023

ETA: 7/27, EOD
Availability: Any

Copy link
Member

@jch1013 jch1013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are being merged from personal fork to gh-pages, and the changes match the changes outlined by the issue. Website looks as it should, with "JS" being removed from the tools section. A few additional spaces seem to have been removed for consistency, but there appears to be no visual impact and I think it should be fine as long as the merge team is ok with it.
Also, I didn't see any screenshots of the visual changes in the pull request, please try to include these when you are able to so the merge team can easily review the pull request.
Nice work overall!

@t-will-gillis t-will-gillis self-requested a review July 30, 2023 16:07
Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @evanhesketh - Great job! Your branches are good, you linked the issue, and you provided visuals before and after. (Thanks for working with @jch1013 on the screenshots!)

One minor note: please provide the "Why did you make the changes (we will use this info to test)?" This does not need to be elaborate and you can use the original issue i.e. "We need to refactor the tools data in the .md file so that in the future we will be able to add a dropdown filter to the "Projects Check" page."

Thanks for working on this!

@kwangric
Copy link
Member

Hey @evanhesketh! If you've made the requested changes, you can re-request reviews from the assigned reviewers so they know when to take a look at your PR again.

Review

@t-will-gillis
Copy link
Member

Thanks for adding the reason for the change to the description!

@t-will-gillis t-will-gillis merged commit 15006f7 into hackforla:gh-pages Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) P-Feature: Projects page https://www.hackforla.org/projects/ p-feature: Projects-check We use this page to check to make sure that teams are using the Technology section correctly role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Tools data for hellogov.md
4 participants