-
-
Notifications
You must be signed in to change notification settings - Fork 781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Tools Data for hellogov.md #5104
Refactor Tools Data for hellogov.md #5104
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
ETA: 7/27, EOD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes are being merged from personal fork to gh-pages, and the changes match the changes outlined by the issue. Website looks as it should, with "JS" being removed from the tools section. A few additional spaces seem to have been removed for consistency, but there appears to be no visual impact and I think it should be fine as long as the merge team is ok with it.
Also, I didn't see any screenshots of the visual changes in the pull request, please try to include these when you are able to so the merge team can easily review the pull request.
Nice work overall!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @evanhesketh - Great job! Your branches are good, you linked the issue, and you provided visuals before and after. (Thanks for working with @jch1013 on the screenshots!)
One minor note: please provide the "Why did you make the changes (we will use this info to test)?" This does not need to be elaborate and you can use the original issue i.e. "We need to refactor the tools
data in the .md file so that in the future we will be able to add a dropdown filter to the "Projects Check" page."
Thanks for working on this!
Hey @evanhesketh! If you've made the requested changes, you can re-request reviews from the assigned reviewers so they know when to take a look at your PR again. |
Thanks for adding the reason for the change to the description! |
Fixes #4807
What changes did you make?
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Project list:Project detail:
Visuals after changes are applied
Project list:Project detail: