-
-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor img tag in Getting Started page #5049
Refactor img tag in Getting Started page #5049
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
Review ETA: 7/22 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there, I see that the changes are being correctly merged from your personal branch into hackforla:gh-pages and that you linked to the issue. The trailing slash in the image tag was removed as specified in the original issue and there are no visual changes to the site. Nicely done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, everything looks good on my end!
@roslynwythe done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @yujioshiro! Everything's looking good — the branching is set up correctly, the corresponding linked issue is linked, the requested change was made perfectly (removing the ending slash in the img
tag on line 172), and this change didn't affect the appearance of the Getting Started page on all views in Docker.
Thank you for taking up this issue! 🙌🏼
Fixes #4415
What changes did you make?
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Refactored code, no visual changes to website.