Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor img tag in Getting Started page #5049

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

yujioshiro
Copy link
Member

Fixes #4415

What changes did you make?

  • Refactored the img tag in the Getting Started page

Why did you make the changes (we will use this info to test)?

  • to maintain the consistency of img tags with the rest of the codebase

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Refactored code, no visual changes to website.

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b yujioshiro-refactor-img-tag-4415 gh-pages
git pull https://github.com/yujioshiro/hfla-website.git refactor-img-tag-4415

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Getting Started https://www.hackforla.org/getting-started Feature: Refactor HTML size: 0.25pt Can be done in 0.5 to 1.5 hours labels Jul 22, 2023
@whitneywind whitneywind self-requested a review July 22, 2023 20:06
@whitneywind
Copy link
Member

Review ETA: 7/22
Availability: 1-3pm 7/22

Copy link
Member

@whitneywind whitneywind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there, I see that the changes are being correctly merged from your personal branch into hackforla:gh-pages and that you linked to the issue. The trailing slash in the image tag was removed as specified in the original issue and there are no visual changes to the site. Nicely done!

Copy link
Member

@ronaldpaek ronaldpaek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, everything looks good on my end!

@ronaldpaek
Copy link
Member

@roslynwythe done

Copy link
Member

@adrianang adrianang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yujioshiro! Everything's looking good — the branching is set up correctly, the corresponding linked issue is linked, the requested change was made perfectly (removing the ending slash in the img tag on line 172), and this change didn't affect the appearance of the Getting Started page on all views in Docker.

Thank you for taking up this issue! 🙌🏼

@adrianang adrianang merged commit 8ab44fb into hackforla:gh-pages Jul 28, 2023
@yujioshiro yujioshiro deleted the refactor-img-tag-4415 branch July 28, 2023 18:36
awellsbiz pushed a commit to awellsbiz/website that referenced this pull request Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Refactor HTML good first issue Good for newcomers P-Feature: Getting Started https://www.hackforla.org/getting-started role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

img Tag Refactor: Getting Started page - step-img-icon schedule.png
4 participants