-
-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DO NOT REVIEW: Prettier and research on setup via CL and Plugin #5023
Draft
ronaldpaek
wants to merge
36
commits into
hackforla:gh-pages
Choose a base branch
from
ronaldpaek:prettier-test
base: gh-pages
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is another option we could explore https://antfu.me/posts/why-not-prettier. Most people like to split up linters and formatters, but we could have our linter do both if we want. Since a lot of people seem to be apprehensive about being prettier. |
ronaldpaek
changed the title
Prettier and research on setup via CL and Plugin
DO NOT REVIEW: Prettier and research on setup via CL and Plugin
Oct 23, 2023
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4059
What changes did you make?
Why did you make the changes (we will use this info to test)?
And in the terminal is prettier, saying things should be consistent and in double quotes, which will make it very fast/easy to open a file and not really even have to think but have prettier tell you to make to have consistent code with the rules you set