Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug with GHA where Update labels do not get applied to Issues with Closed PRs 4839 #4908

Merged
merged 2 commits into from
Jul 12, 2023
Merged

Fixed bug with GHA where Update labels do not get applied to Issues with Closed PRs 4839 #4908

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef3c1c5
Updated add-update-label-weekly to add labels to issues that are link…
LRenDO Jul 1, 2023
7a4bd4e
Merge branch 'gh-pages' of https://github.com/LRenDO/website into fix…
LRenDO Jul 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions github-actions/trigger-schedule/add-update-label-weekly/add-label.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,13 +145,23 @@ function isTimelineOutdated(timeline, issueNum, assignees) { // assignees is an
for (let i = timeline.length - 1; i >= 0; i--) {
let eventObj = timeline[i];
let eventType = eventObj.event;
// isLinkedIssue checks if the 'body'(comment) of the event mentions fixes/resolves/closes this current issue
let isOpenLinkedPullRequest = eventType === 'cross-referenced' && isLinkedIssue(eventObj, issueNum) && eventObj.source.issue.state === 'open';

// if cross-referenced and fixed/resolved/closed by assignee, remove all update-related labels, remove all three labels
if (eventType === 'cross-referenced' && isLinkedIssue(eventObj, issueNum) && assignees.includes(eventObj.actor.login)) { // isLinkedIssue checks if the 'body'(comment) of the event mentioned closing/fixing/resolving this current issue
console.log(`Issue #${issueNum} fixed/resolved/closed by assignee, remove all update-related labels`);
// if cross-referenced and fixed/resolved/closed by assignee and the pull
// request is open, remove all update-related labels
// Once a PR is opened, we remove labels because we focus on the PR not the issue.
if (isOpenLinkedPullRequest && assignees.includes(eventObj.actor.login)) {
console.log(`Assignee fixes/resolves/closes Issue #${issueNum} in with an open pull request, remove all update-related labels`);
return { result: false, labels: '' } // remove all three labels
}

// If the event is a linked PR and the PR is closed, it will continue through the
// rest of the conditions to receive the appropriate label.
else if(eventType === 'cross-referenced' && eventObj.source.issue.state === 'closed') {
console.log(`Pull request linked to Issue #${issueNum} is closed.`);
}

let eventTimestamp = eventObj.updated_at || eventObj.created_at;

// update the lastCommentTimestamp if this is the last (most recent) comment by an assignee
Expand Down