Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check dependabot version updates to wr-pr-instructions.yml 4830 #4847

Merged

Conversation

t-will-gillis
Copy link
Member

Fixes #4830

What changes did you make and why did you make them ?

  • Tested updating the package version in the file wr-pr-instructions.yml per the dependabot suggestions:
    • Tested changing uses: actions/github-script@v4 with uses: actions/github-script@v6 per 4734
    • Tested changing uses: actions/checkout@v2 with uses: actions/checkout@v3 per 4735
    • The test for updating uses: actions/github-script@v4 FAILS. Updating this package breaks the GHA and therefore this should not be updated. The test changing uses: actions/checkout@v2 with uses: actions/checkout@v3 appears to be successful.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

None

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b t-will-gillis-check-version-updates-4830 gh-pages
git pull https://github.com/t-will-gillis/website.git check-version-updates-4830

@t-will-gillis t-will-gillis changed the title Update wr-pr-instructions.yml Check dependabot version updates to wr-pr-instructions.yml 4830 Jun 16, 2023
@github-actions github-actions bot added role: back end/devOps Tasks for back-end developers Complexity: Medium Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms size: 1 pt labels Jun 16, 2023
@blulady blulady self-requested a review June 18, 2023 22:29
Copy link
Member

@blulady blulady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pulled this pr, pushed it up, made it my main branch. Then I created the PR and added an issue number that was already made. When the PR was created, the instructions to review the PR were added to the pr.

@t-will-gillis t-will-gillis merged commit a79f9be into hackforla:gh-pages Jun 19, 2023
@t-will-gillis t-will-gillis deleted the check-version-updates-4830 branch June 19, 2023 01:22
blulady pushed a commit to blulady/website_old that referenced this pull request Jun 19, 2023
ronaldpaek pushed a commit to ronaldpaek/website that referenced this pull request Jun 28, 2023
@ExperimentsInHonesty ExperimentsInHonesty added size: 1pt Can be done in 4-6 hours and removed size: 1 pt labels Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms role: back end/devOps Tasks for back-end developers size: 1pt Can be done in 4-6 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verify dependabot version updates to GHAs for wr-pr-instructions.yml
3 participants