Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update labels: Issue Template: alt-text-audit--dev #4844

Merged
merged 2 commits into from
Jun 18, 2023
Merged

Update labels: Issue Template: alt-text-audit--dev #4844

merged 2 commits into from
Jun 18, 2023

Conversation

Sk-223
Copy link
Member

@Sk-223 Sk-223 commented Jun 16, 2023 •
edited
Loading

Fixes #4477

What changes did you make and why did you make them ?

  • Updated labels string

    • From:
      labels: 'Feature: Accessibility, good first issue, ready for dev lead, role: back end/devOps, role: front end, size: 1pt

    • To:
      labels: ['Feature: Accessibility', 'good first issue', 'ready for dev lead', 'role: back end/devOps', 'role: front end', 'size: 1pt', 'Complexity: Missing']

  • Updated labels to show added "Complexity: Missing"

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

  • No visual changes to the website.

Resources/Instructions

For PM, Merge Team, or Tech Lead

  • Once the pull request associated with this issue is approved and merged, please update and edit epic Creating issues to Add Missing Labels to Issue Templates #4307 by
    • Checking off the dependency for this issue
    • If all dependencies are checked off, please move issue to the New Issue Approval column and remove the Dependency label

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b Sk-223-update-labels-4477 gh-pages
git pull https://github.com/Sk-223/website.git update-labels-4477

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly size: 0.5pt Can be done in 3 hours or less labels Jun 16, 2023
@kiwookim kiwookim self-requested a review June 17, 2023 07:48
@kiwookim
Copy link
Member

Availability: W - F 9-5PM
ETA: 6/22 EOD

roslynwythe
roslynwythe requested changes Jun 18, 2023
View reviewed changes
Copy link
Member

@roslynwythe roslynwythe left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Sk-223 thank you for a great job on this PR. Your code change was clean and correct, you followed an involved test procedure and you created a PR with correctly formed branches. My only request is that in the PR, for the convenience of the other reviewers, could you add a bullet point with the updated labels string, and another bullet point explaining that the changes were made so the GitHub bot would not remove any labels. Also under "Screenshots of Proposed Changes of the website", you can write "No visual changes to the website". Thank you

@Sk-223 Sk-223 mentioned this pull request Jun 18, 2023
Closed
6 tasks
Sebster3
Sebster3 approved these changes Jun 18, 2023
View reviewed changes
Copy link
Member

@Sebster3 Sebster3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Sk-223, great job on this PR! The branches are set correctly, the changes were done neatly, and the issue template in your fork of the repo displays the correct default labels. Approved 👍🏽

roslynwythe
roslynwythe approved these changes Jun 18, 2023
View reviewed changes
Copy link
Member

@roslynwythe roslynwythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Sk-223 for your work on this issue and being responsive to requests for changes.

@roslynwythe roslynwythe merged commit 9d05848 into hackforla:gh-pages Jun 18, 2023
blulady pushed a commit to blulady/website_old that referenced this pull request Jun 19, 2023
@Sk-223 @blulady
Update labels: Issue Template: alt-text-audit--dev (hackforla#4844)
9e58cac
ronaldpaek pushed a commit to ronaldpaek/website that referenced this pull request Jun 28, 2023
@Sk-223 @ronaldpaek
Update labels: Issue Template: alt-text-audit--dev (hackforla#4844)
337ac0c
@adrianang adrianang mentioned this pull request Jul 10, 2023
Merged
4 tasks
@Sk-223 Sk-223 deleted the update-labels-4477 branch October 29, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sebster3 Sebster3 Sebster3 approved these changes

@roslynwythe roslynwythe roslynwythe approved these changes

@kiwookim kiwookim Awaiting requested review from kiwookim

Assignees
No one assigned
Labels
Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly good first issue Good for newcomers role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update labels: Issue Template: alt-text-audit--dev
4 participants
@Sk-223 @kiwookim @roslynwythe @Sebster3