Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Home Unite Us technology array - Amazon Cognito / OIDC / OAuth2 - 4782 #4843

Conversation

matthewmpan
Copy link
Member

@matthewmpan matthewmpan commented Jun 16, 2023

Fixes #4782

What changes did you make and why did you make them ?

  • Removed the line - Amazon Cognito / OIDC / OAuth2
  • Split the technologies into three separate lines
    - Amazon Cognito
    - OIDC
    - OAuth2
  • The technologies are no longer truncated on the filter tag and can be filtered independently

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

Screen Shot 2023-06-15 at 4 34 21 PM

Visuals after changes are applied

Screen Shot 2023-06-15 at 4 56 52 PM

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b matthewmpan-update-home-unite-us-technology-4782 gh-pages
git pull https://github.com/matthewmpan/website.git update-home-unite-us-technology-4782

@github-actions github-actions bot added role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Complexity: Small Take this type of issues after the successful merge of your second good first issue P-Feature: Projects page https://www.hackforla.org/projects/ size: 0.5pt Can be done in 3 hours or less labels Jun 16, 2023
@LOSjr4 LOSjr4 self-requested a review June 16, 2023 01:50
@LOSjr4
Copy link
Member

LOSjr4 commented Jun 16, 2023

Availability: weekdays 8AM-10AM
ETA: 6/16 10AM

Copy link
Member

@LOSjr4 LOSjr4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes on home-unite-us.md look clean. I see the three technologies separated with commas instead of slashes on docker. I see the three technologies show up individually on the filter selections, and they each point to Home Unite Us when toggled.
Good work @matthewmpan ! Thank you for taking this issue.

@t-will-gillis t-will-gillis self-requested a review June 18, 2023 15:28
@Sebster3 Sebster3 self-requested a review June 18, 2023 16:18
@Sebster3
Copy link
Member

Availability: 9AM-1PM
ETA: 6/18 10AM

Copy link
Member

@Sebster3 Sebster3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work here, @matthewmpan! The branches are correct, the edits were made neatly, and the page renders properly in my local environment, and the filter functionality is consistent with what is expected. Approved 👍🏽

@t-will-gillis t-will-gillis merged commit 3decf40 into hackforla:gh-pages Jun 18, 2023
blulady pushed a commit to blulady/website_old that referenced this pull request Jun 18, 2023
blulady pushed a commit to blulady/website_old that referenced this pull request Jun 18, 2023
blulady pushed a commit to blulady/website_old that referenced this pull request Jun 18, 2023
blulady pushed a commit to blulady/website_old that referenced this pull request Jun 18, 2023
blulady pushed a commit to blulady/website_old that referenced this pull request Jun 18, 2023
@matthewmpan
Copy link
Member Author

@LOSjr4 & @Sebster3 Thanks for the reviews! @t-will-gillis Thanks for the merge!

ronaldpaek pushed a commit to ronaldpaek/website that referenced this pull request Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue P-Feature: Projects page https://www.hackforla.org/projects/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Home Unite Us Project File to split up long technology name
4 participants