-
-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Home Unite Us technology array - Amazon Cognito / OIDC / OAuth2 - 4782 #4843
Update Home Unite Us technology array - Amazon Cognito / OIDC / OAuth2 - 4782 #4843
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
Availability: weekdays 8AM-10AM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes on home-unite-us.md look clean. I see the three technologies separated with commas instead of slashes on docker. I see the three technologies show up individually on the filter selections, and they each point to Home Unite Us when toggled.
Good work @matthewmpan ! Thank you for taking this issue.
Availability: 9AM-1PM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work here, @matthewmpan! The branches are correct, the edits were made neatly, and the page renders properly in my local environment, and the filter functionality is consistent with what is expected. Approved 👍🏽
…ering (hackforla#4843) Co-authored-by: Matt Pan <[email protected]>
…ering (hackforla#4843) Co-authored-by: Matt Pan <[email protected]>
…ering (hackforla#4843) Co-authored-by: Matt Pan <[email protected]>
…ering (hackforla#4843) Co-authored-by: Matt Pan <[email protected]>
…ering (hackforla#4843) Co-authored-by: Matt Pan <[email protected]>
@LOSjr4 & @Sebster3 Thanks for the reviews! @t-will-gillis Thanks for the merge! |
…ering (hackforla#4843) Co-authored-by: Matt Pan <[email protected]>
Fixes #4782
What changes did you make and why did you make them ?
- Amazon Cognito / OIDC / OAuth2
- Amazon Cognito
- OIDC
- OAuth2
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied