Add frameworks #460 #480
Closed
Add frameworks #460 #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnk
requested changes
May 1, 2020
_layouts/project.html
Outdated
| @@ -182,6 +185,21 @@ <h4 style='color:#333'>Resources</h4> | |||
| } | |||
| </script> | |||
|
|
|||
| <!--Script for adding frameworks to "Frameworks" Section--> | |||
There was a problem hiding this comment.
@ruben1s I don't think we need javascript to fill in the frameworks. The data for this is in the project.md file itself - not in the JSON data we scrape from GitHub's api.
Can you please take this out and see if frameworks display? If so, please edit your pull request. If not, please get back to me so I can look more carefully to see why we need JS to do this.
4 tasks
|
I made the change @cnk requested. |
cnk
added a commit
that referenced
this pull request
May 3, 2020
* Fixes 460 * Fixes 460 * Capitalize Jekyll and GitHub Pages * Correct capitalization of PostgreSQL Co-authored-by: ruben1s <[email protected]>
|
Had to manually resolve conflicts so had to create an alternate pull request #491 that contained these updates |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #460