Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added new team member to hfla site project profile #4789

Conversation

Dprosser4
Copy link
Member

Fixes #4758

What changes did you make and why did you make them ?

  • added new team members information within the leadership variable
  • specific file changed _projects/website.md
  • confirmed all links working for new team member

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied Screenshot 2023-06-06 at 12 34 25 PM
Visuals after changes are applied Screenshot 2023-06-06 at 12 34 07 PM

@github-actions
Copy link

github-actions bot commented Jun 6, 2023

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b Dprosser4-add-new-team-member-hflaweb-project-profile-4758 gh-pages
git pull https://github.com/Dprosser4/website.git add-new-team-member-hflaweb-project-profile-4758

@github-actions github-actions bot added role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe Complexity: Small Take this type of issues after the successful merge of your second good first issue size: 0.25pt Can be done in 0.5 to 1.5 hours labels Jun 6, 2023
@steven-positive-tran
Copy link
Member

Availability: W-F
ETA: Friday 11pm

@steven-positive-tran steven-positive-tran self-requested a review June 7, 2023 05:22
@LOSjr4 LOSjr4 self-requested a review June 7, 2023 15:45
Copy link
Member

@LOSjr4 LOSjr4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see formatting for addition to leadership in _projects/website.md were done correctly. I verified all links worked and went to the correct profiles. Docker preview looks good. @Dprosser4 left a good description of what was done and why. They also correctly included before and after pictures.
Nice clean work @Dprosser4 !

@ldietz08 ldietz08 self-requested a review June 8, 2023 14:19
@ldietz08
Copy link
Member

ldietz08 commented Jun 8, 2023

ETA: 6/11 EOD
Availability: M-F 4pm-6pm

Copy link
Member

@steven-positive-tran steven-positive-tran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay.

The changes of adding the new team member shows up docker in both firefox and in edge. Code changes seem in line with the issues that were addressed. Branches look good.

Looks good and thank you for taking up this issue.

Copy link
Member

@ldietz08 ldietz08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Dylan! It looks like the pull request was done in the correct branch and you linked to the issue. As requested, a new merge team member was added to the website markdown file. The visual changes reflect what I see in my local environment.

Nice job!

@Adastros Adastros merged commit 99f735a into hackforla:gh-pages Jun 14, 2023
ronaldpaek pushed a commit to ronaldpaek/website that referenced this pull request Jun 28, 2023
* added new team member to hfla site project profile

* restored unintentional change on line 6 alt variable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Project Profile: Hackforla.org Website
5 participants