-
-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added new team member to hfla site project profile #4789
added new team member to hfla site project profile #4789
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
Availability: W-F |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see formatting for addition to leadership in _projects/website.md were done correctly. I verified all links worked and went to the correct profiles. Docker preview looks good. @Dprosser4 left a good description of what was done and why. They also correctly included before and after pictures.
Nice clean work @Dprosser4 !
ETA: 6/11 EOD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay.
The changes of adding the new team member shows up docker in both firefox and in edge. Code changes seem in line with the issues that were addressed. Branches look good.
Looks good and thank you for taking up this issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Dylan! It looks like the pull request was done in the correct branch and you linked to the issue. As requested, a new merge team member was added to the website markdown file. The visual changes reflect what I see in my local environment.
Nice job!
* added new team member to hfla site project profile * restored unintentional change on line 6 alt variable
Fixes #4758
What changes did you make and why did you make them ?
_projects/website.md
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied