-
-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated pre-work-template---design.md labels #4767
Updated pre-work-template---design.md labels #4767
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
ETA: 6/2/23 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @LRenDO thank you for working on this issue. It looks good so far. For the convenience of reviewers, please go to the issue and copy the section "Link for Reviewers" (along with the text/link) into this PR. Thank you !
Instructions for testing updated issue templates:
|
Hi @roslynwythe! Whoops, looks like I was moving too quickly and didn't get the whole section when I copied. Should be fixed now. Thanks for catching that! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've verified that the changes requested in issue #4767 have been correctly implemented in the .github/ISSUE_TEMPLATE/pre-work-template---design.md
file. After following the testing instructions provided by @roslynwythe and @blulady, I was able to successfully add and implement the labels on the pre-work template --design when creating a new issue.
I'm very impressed by the your attention to detail in your PR report. You took the time and effort to clearly state where file changes where taking place, and what file changes were being made. Furthermore, you quickly made requested changes to make the testing process easier. Excellent work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @LRenDO for great work on this issue. Your code change is correct and clean, you completed the test procedure and displayed the test template URL, and created a well-formed Pull Request which describes your work.
Fixes #4480
What changes did you make and why did you make them ?
.github/ISSUE_TEMPLATE/pre-work-template---design.md
from
labels: 'Feature: Onboarding/Contributing.md, prework, role: design, size: 1pt'
to
labels: ['Feature: Onboarding/Contributing.md', 'prework', 'role: design', 'size: 1pt', 'Complexity: Missing']
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied
For PR Reviewers and Merge Team
To review this issue, click the link below under "Link for reviewers" and verify that the labels match the updated labels string in the issue.
Link for Reviewers
This URL will be inserted by the dev during the test process and will be used by reviewers to preview the updated template.
URL of the issue branch on the test Repository: Updated Pre-work Design Template
For PM, Merge Team, or Tech Lead