Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated pre-work-template---design.md labels #4767

Merged

Conversation

LRenDO
Copy link
Member

@LRenDO LRenDO commented Jun 1, 2023

Fixes #4480

What changes did you make and why did you make them ?

  • Updated labels in .github/ISSUE_TEMPLATE/pre-work-template---design.md
    from
    labels: 'Feature: Onboarding/Contributing.md, prework, role: design, size: 1pt'
    to
    labels: ['Feature: Onboarding/Contributing.md', 'prework', 'role: design', 'size: 1pt', 'Complexity: Missing']
  • Verified labels appeared correctly in the pre-work design template
  • Per the issue, this was done to avoid the GitHub bot taking off the labels when devs add them to issues.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied
Visuals after changes are applied

For PR Reviewers and Merge Team
To review this issue, click the link below under "Link for reviewers" and verify that the labels match the updated labels string in the issue.

Link for Reviewers
This URL will be inserted by the dev during the test process and will be used by reviewers to preview the updated template.
URL of the issue branch on the test Repository: Updated Pre-work Design Template

For PM, Merge Team, or Tech Lead

@github-actions
Copy link

github-actions bot commented Jun 1, 2023

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b LRenDO-update-pre-work-template-labels-4480 gh-pages
git pull https://github.com/LRenDO/website.git update-pre-work-template-labels-4480

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly size: 0.5pt Can be done in 3 hours or less labels Jun 1, 2023
@one2code one2code self-requested a review June 1, 2023 22:44
@one2code
Copy link
Member

one2code commented Jun 2, 2023

ETA: 6/2/23
Availability 8-10PM EST, 6/2/23

@roslynwythe roslynwythe self-requested a review June 4, 2023 16:50
Copy link
Member

@roslynwythe roslynwythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @LRenDO thank you for working on this issue. It looks good so far. For the convenience of reviewers, please go to the issue and copy the section "Link for Reviewers" (along with the text/link) into this PR. Thank you !

@blulady
Copy link
Member

blulady commented Jun 4, 2023

Instructions for testing updated issue templates:

  • Push your issue branch to your fork of the website repository, as described in Section 3.1.a of CONTRIBUTING doc, for example: git push --set-upstream origin test-update-labels-1234
  • The response from the push command will include the URL for creating a pull request. Copy/Paste the URL below for use after testing:
    [REPLACE THIS TEXT WITH URL FOR CREATING PR]
  • Browse to your fork of the website repository and click Settings
Screenshot of Repository Settings

image

  • Change the default branch to the new issue branch
Screenshot of Default Branch Setting

image

  • Further down on the settings page under Features, check the Issues checkbox
Screenshot of Issues Checkbox

image

  • Browse to the Issues page, then click Labels
Screenshot - creating labels in the test Repo

image

  • Create labels corresponding to each label that was listed in the updated issue template. The color of the labels don't have to match those on the hackforla/website repository, but the text of the labels must match exactly.
  • From the Issues page, click New Issue then locate the template updated by your issue, and click Get Started to open the issue template.
  • Copy/Paste the URL of the issue template into the Resources section of the issue, replacing the text: [REPLACE THIS TEXT WITH URL OF THE ISSUE TEMPLATE ON THE TEST REPO]
    This will enable others to check the template.
  • Verify that the labels listed in the issue all appear on the issue template. If there is a discrepancy between the labels listed in the issue and the labels that appear on the issue template, ask a dev lead or merge team member for help.
  • If the labels listed in the issue match those listed on the issue template, complete the PR process by visiting the URL saved from the push command
  • Copy these sections from the Issue into the PR
    • "For PR Reviewers and Merge Team"
    • "Link for Reviewers"
    • "For PM, Merge Team, or Tech Lead"

@LRenDO LRenDO requested a review from roslynwythe June 5, 2023 18:51
@LRenDO
Copy link
Member Author

LRenDO commented Jun 5, 2023

Hi @LRenDO thank you for working on this issue. It looks good so far. For the convenience of reviewers, please go to the issue and copy the section "Link for Reviewers" (along with the text/link) into this PR. Thank you !

Hi @roslynwythe! Whoops, looks like I was moving too quickly and didn't get the whole section when I copied. Should be fixed now. Thanks for catching that!

Copy link
Member

@one2code one2code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've verified that the changes requested in issue #4767 have been correctly implemented in the .github/ISSUE_TEMPLATE/pre-work-template---design.md file. After following the testing instructions provided by @roslynwythe and @blulady, I was able to successfully add and implement the labels on the pre-work template --design when creating a new issue.

I'm very impressed by the your attention to detail in your PR report. You took the time and effort to clearly state where file changes where taking place, and what file changes were being made. Furthermore, you quickly made requested changes to make the testing process easier. Excellent work!

Copy link
Member

@roslynwythe roslynwythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @LRenDO for great work on this issue. Your code change is correct and clean, you completed the test procedure and displayed the test template URL, and created a well-formed Pull Request which describes your work.

@roslynwythe roslynwythe merged commit 7a799d1 into hackforla:gh-pages Jun 8, 2023
@LRenDO LRenDO deleted the update-pre-work-template-labels-4480 branch June 9, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly good first issue Good for newcomers role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update labels: Issue Template: pre-work-template---design
4 participants