Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit System Audit Text #4750

Merged
merged 1 commit into from
Jun 18, 2023

Conversation

DakuwoN
Copy link
Member

@DakuwoN DakuwoN commented May 29, 2023

Fixes #4482

What changes did you make and why did you make them ?

  • Added labels with [] (brackets) in the markdown file
  • These brackets add the labels from the Missing series
  • Prevents the GitHub bot from taking the labels off when developers add new issues.

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly size: 0.5pt Can be done in 3 hours or less labels May 29, 2023
@DakuwoN DakuwoN changed the title Edit System Audit Text #4482 Edit System Audit Text May 29, 2023
@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b DakuwoN-design-system-audit-4482 gh-pages
git pull https://github.com/DakuwoN/website.git design-system-audit-4482

@Mayank2808sharma Mayank2808sharma self-requested a review May 29, 2023 02:17
Copy link
Member

@Mayank2808sharma Mayank2808sharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DakuwoN
Copy link
Member Author

DakuwoN commented May 29, 2023

Thank you @Mayank2808sharma I am not sure how to test it, but I did run those commands in git... lol

@blulady blulady requested review from EdASalazar and removed request for ExperimentsInHonesty May 31, 2023 02:16
Copy link
Member

@EdASalazar EdASalazar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@roslynwythe roslynwythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @DakuwoN Thank you for taking on this issue. This Pull Request looks good. The branches are setup correctly and the code change appears to be correct and clean. However to confirm the updated template is correct, I need the URL of the template in your test repository. Please edit Issue #4482, under "Link for Reviewer", replacing the text [REPLACE THIS TEXT AND BRACKETS WITH THE URL] with that URL. Then complete the test procedure outlined in this comment, by copying the listed sections from the Issue, into this PR, under the "What changes did you make..." section. Please send me a Slack message if you have any questions.

One other minor request: please provide a more descriptive name for the PR. The key point is that you have modified the labels on the "Design System Audit" template. Thanks

@DakuwoN
Copy link
Member Author

DakuwoN commented Jun 13, 2023

Hi @DakuwoN Thank you for taking on this issue. This Pull Request looks good. The branches are setup correctly and the code change appears to be correct and clean. However to confirm the updated template is correct, I need the URL of the template in your test repository. Please edit Issue #4482, under "Link for Reviewer", replacing the text [REPLACE THIS TEXT AND BRACKETS WITH THE URL] with that URL. Then complete the test procedure outlined in this comment, by copying the listed sections from the Issue, into this PR, under the "What changes did you make..." section. Please send me a Slack message if you have any questions.

One other minor request: please provide a more descriptive name for the PR. The key point is that you have modified the labels on the "Design System Audit" template. Thanks

I explained the changes I made and why in the first comment above? Is this supposed to go elsewhere?

Copy link
Member

@roslynwythe roslynwythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @DakuwoN thank you for providing the URL. I looked and it looks fine. I just have two tiny requests:
Please update the name of the PR just to indicate that you updated labels on the "Edit System Audit: Text" template.
Please see the last Action Item in this comment. It is asking you to copy a few sections of text from the issue into the PR. After doing that please check off those last check boxes.

@DakuwoN
Copy link
Member Author

DakuwoN commented Jun 18, 2023

For PR Reviewers and Merge Team
To review this issue, click the link below under "Link for reviewers" and verify that the labels match the updated labels string in the issue.

Link for Reviewers
This URL will be inserted by the dev during the test process and will be used by reviewers to preview the updated template.
URL of the issue branch on the test Repository: #4482
For PM, Merge Team, or Tech Lead

Once the pull request associated with this issue is approved and merged, please update and edit epic #4307 by
Checking off the dependency for this issue
If all dependencies are checked off, please move issue to the New Issue Approval column and remove the Dependency label

Copy link
Member

@roslynwythe roslynwythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @DakuwoN Thank you for making all of the requested changes. Due to the need to test the updated template, this was more involved than most of our good first issues and we really appreciate your attention and effort to complete all the details.

@roslynwythe roslynwythe merged commit d70f869 into hackforla:gh-pages Jun 18, 2023
blulady pushed a commit to blulady/website_old that referenced this pull request Jun 18, 2023
blulady pushed a commit to blulady/website_old that referenced this pull request Jun 18, 2023
blulady pushed a commit to blulady/website_old that referenced this pull request Jun 18, 2023
blulady pushed a commit to blulady/website_old that referenced this pull request Jun 18, 2023
blulady pushed a commit to blulady/website_old that referenced this pull request Jun 18, 2023
ronaldpaek pushed a commit to ronaldpaek/website that referenced this pull request Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly good first issue Good for newcomers role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edit System Audit: text
4 participants