Update Img tag refactor: citizen engagement

[oliviazhai]

Fixes #4449

What changes did you make and why did you make them ?

• Remove the ending slash in the img HTML tag in citizen engagement page

there are no visual changes

[github-actions]

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b oliviazhai-update-Img-Tag-Refactor gh-pages
git pull https://github.com/oliviazhai/website.git update-Img-Tag-Refactor

[LOSjr4]

@oliviazhai Thank you for addressing the slash in this issue. Your pull request was submitted correctly. However I noticed the original issue also showed the space taken out in addition to the slash.

Please go back into your branch, remove the space, and commit/push again.

Also FYI, I appreciate your effort to include pictures, but regarding this issue, there wasn't any changes to show. It's important that we check Docker to make sure our changes don't break anything, but we don't always supply pictures if changes are not visible to the site.

[93Belen]

Availability: Tuesday, Thursday and Sunday from 6am to 6pm
ETA: 5/30/23 by 6pm

[roslynwythe]

Hi @oliviazhai, I agree with the points made by @LOSjr4. Since we are aiming for a consistent formatting of HTML, please remove the extra space at the end of the tag, and also please delete the <details> and <summary> tags and simply state that there are no visual changes to the website. But aside from those minor points, the PR looks very good. Thank you!

[93Belen]

I agree with the changes requested so I am just going to wait for that to be fix before I leave the same review :)

[oliviazhai]

Hi @oliviazhai, I agree with the points made by @LOSjr4. Since we are aiming for a consistent formatting of HTML, please remove the extra space at the end of the tag, and also please delete the <details> and <summary> tags and simply state that there are no visual changes to the website. But aside from those minor points, the PR looks very good. Thank you!

Hi,

I just did the change can you review again, thanks for the feedback

[oliviazhai]

@oliviazhai Thank you for addressing the slash in this issue. Your pull request was submitted correctly. However I noticed the original issue also showed the space taken out in addition to the slash. Please go back into your branch, remove the space, and commit/push again.

Also FYI, I appreciate your effort to include pictures, but regarding this issue, there wasn't any changes to show. It's important that we check Docker to make sure our changes don't break anything, but we don't always supply pictures if changes are not visible to the site.

Hi,

thanks so much for the feedback, i did the change can you review it again

[93Belen]

Hi! Great job!
You did the PR from the correct branch, linked the issue and explained what you did.
Now the img element is formatted exactly how described in the Issue.
Great job addressing the changes requested.

[LOSjr4]

Perfect @oliviazhai! Thank you for going back in to remove that space and letting me know to re-review your PR.

[roslynwythe]

Hi @oliviazhai since there are no visual changes to the website, please delete the <details> and <summary> tags in the PR, along with the images, and simply state that there are no visual changes.

[oliviazhai]

Hi @oliviazhai since there are no visual changes to the website, please delete the <details> and <summary> tags in the PR, along with the images, and simply state that there are no visual changes.

Hi, @roslynwythe, I just updated the command,thanks

[roslynwythe]

Hi @oliviazhai great job on this issue. Your code change is clean and correct and it checks out fine in the browser, you setup the branches of the PR correctly and described your work, Thank you!