Refactor tag step img intro 4375 #4680
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
github-actions
bot
added
good first issue
|
Availability: 10 AM - 3PM |
There was a problem hiding this comment.
Hi @Maia-Cochran , merge branches looks good, code is clean and works well on the local machine. But, changes to line 166 seems beyond the scope of this issue. (probably there is another issue written for that change and being worked on by someone else). Please undo the changes on line 166. TIA!
|
Availability: 5/22/23 10 AM - 2PM |
There was a problem hiding this comment.
Hi @Maia-Cochran , thank you for doing the work needed to fix issue 4375.
- The branches look good (going into hackforla: ghpages from your branch)
- Linked issue is stated in PR
- Requested change to line 16 is done correctly.
All of this looks great!
However, can you please undo changes from line 166 as I don't see this as a requested change in issue #4375 . Once this is done, I can approve the PR.
|
Hi all! Changes to line 166 have been reverted to its original state. I apologize for any confusion. Please, let me know if there is anything further you need from me! Thanks! Availability: M-F 9am-6pm MST |
There was a problem hiding this comment.
@Maia-Cochran Thank you for reverting back line 166. Approved!
chrismenke45
requested review from
chrismenke45
and removed request for
chrismenke45,
aalieu and
kotynskm
There was a problem hiding this comment.
Great Work @Maia-Cochran . The changes are being merged into the correct branch and look good on the site.
Fixes #4375
What changes did you make and why did you make them ?
<img class="step-img-intro" src="./assets/images/getting-started/business.png" alt="" />to<img class="step-img-intro" src="./assets/images/getting-started/business.png" alt="">per issue indicationScreenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)