-
-
Notifications
You must be signed in to change notification settings - Fork 781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removed Bitian Zhang & Arpita Pandya #4646
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
Avail: Wed 2-4pm, Thur 10am-16pm |
Hi Belen, Thank you for creating a new branch. For future reference, they like to have the issue number included in your title I did run into an issue and not sure if its on my end. Did you pull from the main gh-pages before creating your branch? After I created a new branch and trying to pull from https://github.com/93Belen/website.git update-project-profile, I'm getting a divergent error and not sure if that is the cause of it or something on my end. @steven-positive-tran is that the case? |
I created the branch in my repo so it has the same code as the previus pull request. Thank you for the clarification about the name! |
Can you try to pull/synchronize your branch with the main branch? I think that'll do the trick. |
I just did, let me know how it goes :) |
I'm running into the same issue I'll wait for either Steven to look at it or @mademarc since I'm not that experienced with PR reviews. |
@steven-positive-tran & @mademarc if you guys could throw an eta on this so we could know when to expect a review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The two members are removed on my browser and everything looks great. I finally got it to work so it was an issue on my end. Sorry for all the confusion.
Thank you! 😄 |
Review ETA: 4/12/2023 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making a new branch in your fork and placing your changes there.
Looks good on both firefox and edge on my machine and the code changes seem in line with the issue in hand
Thank you for taking up this issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @93Belen Good way to go in deleting the unnecessary elements make the UI of the page better and @steven-positive-tran take a look at it as well also thanks @blulady for the heads up.
Hey! I'm sorry I was trying to fix something and I deleted the repo to fork it again without realizing it would affect this request. What do you recommend me to do? I'm so sorry. I can do the pull request again but I dont want to do it until you guys tell me thats what I should do |
This PR was closed and replaced by #4666, therefore moving this to column 'IGNORE: PRs closed without being merged' |
Fixes #4473
What changes did you make and why did you make them ?
I removed Bitian Zhang and Arpita Pandya from the leadership in Hackforla.org Website
This is the second pull request done with the same changes, since the first request was done from the wrong branch.
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied