Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gha update label 4590 #4599

Merged
merged 7 commits into from
May 9, 2023

Conversation

angieyan
Copy link
Member

@angieyan angieyan commented May 4, 2023

Fixes #4590

What changes did you make and why did you make them ?

-Added additional sentence in the the update-instructions-template.md file.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

There is no visual changes.

@github-actions
Copy link

github-actions bot commented May 4, 2023

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b angieyan-GHA-update-label-4590 gh-pages
git pull https://github.com/angieyan/website.git GHA-update-label-4590

@github-actions github-actions bot added role: back end/devOps Tasks for back-end developers Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly Complexity: Small Take this type of issues after the successful merge of your second good first issue size: 0.25pt Can be done in 0.5 to 1.5 hours ready for product labels May 4, 2023
Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@angieyan and I discussed via chat that changes are needed. Her availability is after 5/7 and we will discuss then. Thanks

@angieyan angieyan requested a review from t-will-gillis May 8, 2023 17:42
Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @angieyan - thank you for reverting the yaml file to the original. Everything looks good: the branches are correct, links back to the correct issue, and the changes are per the original issue. We tested on a mock Project Board and the message was displayed as intended.

Great job!

@t-will-gillis t-will-gillis merged commit 67dc558 into hackforla:gh-pages May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly ready for product role: back end/devOps Tasks for back-end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improvements to GHA 'Add Update' Label
2 participants