-
-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Img tag refactor in Getting Started Page - #4417 #4584
Img tag refactor in Getting Started Page - #4417 #4584
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
ETA: 3pm PDT today |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Branches are set up correctly. Pull request includes summary of the changes that were made and why. Requested changes to the img tag are made, and everything looks good in Docker. Great work!
ETA: EoD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is linked to the correct issue and comes from the correct branch. It has a clear and concise description of the changes and the rationale behind them. The code changes are correct. Well done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @kerimedeiros - Great job! Your from-to branches are set up correctly, you are linked back to the issue, and you made the clean and concise changes per the issue. Checking in Docker it appears everything is functioning correctly in different modes. Finally, you are describing which changes you made and why.
Congrats on your first issue, and thanks!
Fixes #4417
What changes did you make and why did you make them ?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)