Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Img tag refactor in Getting Started Page - #4417 #4584

Conversation

kerimedeiros
Copy link
Member

Fixes #4417

What changes did you make and why did you make them ?

  • Removed the trailing slash and extra space from the img tag.
  • Changes made to ensure that the codebase is consistent in how we use HTML tags.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

  • No visual changes as this was a refactoring of an img tag.

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b kerimedeiros-img-tag-refactor-getting-started-4417 gh-pages
git pull https://github.com/kerimedeiros/website.git img-tag-refactor-getting-started-4417

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Getting Started https://www.hackforla.org/getting-started Feature: Refactor HTML size: 0.25pt Can be done in 0.5 to 1.5 hours labels Apr 28, 2023
@kwangric kwangric self-requested a review April 28, 2023 21:46
@kwangric
Copy link
Member

ETA: 3pm PDT today
Availability: Today until 5pm PDT

Copy link
Member

@kwangric kwangric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Branches are set up correctly. Pull request includes summary of the changes that were made and why. Requested changes to the img tag are made, and everything looks good in Docker. Great work!

@StephenTheDev1001 StephenTheDev1001 self-requested a review April 29, 2023 03:47
@StephenTheDev1001
Copy link
Contributor

ETA: EoD
Availability: M-F 10am-12pm

StephenTheDev1001

This comment was marked as duplicate.

Copy link
Contributor

@StephenTheDev1001 StephenTheDev1001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is linked to the correct issue and comes from the correct branch. It has a clear and concise description of the changes and the rationale behind them. The code changes are correct. Well done!

@t-will-gillis t-will-gillis self-requested a review May 1, 2023 02:16
Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kerimedeiros - Great job! Your from-to branches are set up correctly, you are linked back to the issue, and you made the clean and concise changes per the issue. Checking in Docker it appears everything is functioning correctly in different modes. Finally, you are describing which changes you made and why.

Congrats on your first issue, and thanks!

@t-will-gillis t-will-gillis merged commit c5e3fd6 into hackforla:gh-pages May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Refactor HTML good first issue Good for newcomers P-Feature: Getting Started https://www.hackforla.org/getting-started role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

img Tag Refactor: Getting Started page - step-img people.png
4 participants