Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Img Tag Refactor #4398 #4576

Merged

Conversation

katiehermalik
Copy link
Member

Fixes #4398

What changes did you make and why did you make them ?

  • Changed an img HTML tag ending with a slash (<img.../>) to an img tag without an ending slash (<img...>) so that the codebase is consistent with how we use img HTML tags.
  • Check the page remains the same in mobile, tablet, and desktop views as on the current website

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No visual changes.

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b katiehermalik-img-tag-refactor-4398 gh-pages
git pull https://github.com/katiehermalik/website.git img-tag-refactor-4398

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Getting Started https://www.hackforla.org/getting-started Feature: Refactor HTML size: 0.25pt Can be done in 0.5 to 1.5 hours labels Apr 27, 2023
@kwangric kwangric self-requested a review April 28, 2023 18:46
@kwangric
Copy link
Member

ETA: 1pm PDT
Availability: After 12pm PDT today

Copy link
Member

@kwangric kwangric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Branches are set up correctly. Pull request includes a summary of changes made and why.
Requested changes have been made and everything looks good on Docker. Great work!

@StephenTheDev1001 StephenTheDev1001 self-requested a review April 29, 2023 04:05
@StephenTheDev1001
Copy link
Contributor

ETA: EoD
Availability: M-F 10am-12pm

Copy link
Contributor

@StephenTheDev1001 StephenTheDev1001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good description of the changes and rationale behind them. The PR comes from the correct branch and the changes to the code is correct. Good job on your first pull request.

@DeitchDustin DeitchDustin self-requested a review April 30, 2023 02:28
@DeitchDustin
Copy link
Member

ETA: 8pm PST
Availability: April 29th, 2023 7:30pm - 11:00pm

Copy link
Member

@DeitchDustin DeitchDustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Descriptive title with issue number, completed the task as ticket requested. Fantastic job, keep up the good work!

@t-will-gillis t-will-gillis self-requested a review May 1, 2023 02:03
Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @katiehermalik Great job! Your branches are correct, your changes address the issue cleanly and concisely, you are referencing the issue correctly, you have specified the changes you made and why, and finally in Docker everything appears to be functioning as intended.

Congrats on your first issue and thank you!

@t-will-gillis t-will-gillis merged commit 53329d2 into hackforla:gh-pages May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Refactor HTML good first issue Good for newcomers P-Feature: Getting Started https://www.hackforla.org/getting-started role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

img Tag Refactor: Getting Started page - step-img-wide technology.png
5 participants