-
-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Img Tag Refactor #4398 #4576
Img Tag Refactor #4398 #4576
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
ETA: 1pm PDT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Branches are set up correctly. Pull request includes a summary of changes made and why.
Requested changes have been made and everything looks good on Docker. Great work!
ETA: EoD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good description of the changes and rationale behind them. The PR comes from the correct branch and the changes to the code is correct. Good job on your first pull request.
ETA: 8pm PST |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Descriptive title with issue number, completed the task as ticket requested. Fantastic job, keep up the good work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @katiehermalik Great job! Your branches are correct, your changes address the issue cleanly and concisely, you are referencing the issue correctly, you have specified the changes you made and why, and finally in Docker everything appears to be functioning as intended.
Congrats on your first issue and thank you!
Fixes #4398
What changes did you make and why did you make them ?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
No visual changes.