Img Tag Refactor #4401

[graycodesnu]

Fixes #4401

What changes did you make and why did you make them ?

-Changed an img HTML tag ending with a slash (<img.../>) to an img tag without an ending slash (<img...>) so that the codebase is consistent with how we use img HTML tags.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No visual changes.

[github-actions]

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b graycodesnu-img-refactor-4401 gh-pages
git pull https://github.com/graycodesnu/hfla-website.git img-refactor-4401

[agosmou]

LGTM!

[Thinking-Panda]

Availability: M-F 10 AM - 3PM
ETA: 4/27/23

[Thinking-Panda]

Hi @graycodesnu, code changes look good and clean. But, while checking website on my local machine, the donate page is the older version and looks different from the published website. May be there is an issue with the branch you are working on.

[graycodesnu]

Hi @Thinking-Panda, can you provide more detail in terms of the changes you see and what adjustments need to be made on my end?
I synced my forked repo + pulled before creating a new branch, and then pulled the upstream changes before submitting my pull request. I also double-checked for any changes via Docker on my end before pushing and creating this request. Additionally, I did not work on a donate page, as these changes were only made to the getting-started.html file.

[Thinking-Panda]

Hi @Thinking-Panda, can you provide more detail in terms of the changes you see and what adjustments need to be made on my end? I synced my forked repo + pulled before creating a new branch, and then pulled the upstream changes before submitting my pull request. I also double-checked for any changes via Docker on my end before pushing and creating this request. Additionally, I did not work on a donate page, as these changes were only made to the getting-started.html file.

@graycodesnu , looks like you have followed the necessary steps before submitting a pull request. I also understand that you did not work on the donate page. I still see the older version of the donate page on my local machine. Did you try pulling from upstream again?

[graycodesnu]

@agosmou, you've already approved this request, but are you seeing the same issues @Thinking-Panda is? I understand version control differently and don't think this will be an issue, but if I need to take time to brush up, I'd rather have a second set of eyes.

[jdingeman]

@Thinking-Panda - you may be seeing the page before the cache was emptied and reloaded/the page was rebuilt in Docker. The file he changed doesn't affect the Donate page.

Changes not needed