Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed '/' from the step-img-icon img tag that wraps id.png #4528

Merged
merged 1 commit into from
Apr 18, 2023
Merged

Removed '/' from the step-img-icon img tag that wraps id.png #4528

merged 1 commit into from
Apr 18, 2023

Conversation

one2code
Copy link
Member

@one2code one2code commented Apr 17, 2023

Fixes #4400

What changes did you make and why did you make them ?

Removed the '/' from the step-img-icon img tag that wraps id.png, to maintain more consistent styling throughout the getting-started.html page

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

N/A, changes are code only. The id.png file displays correctly during testing in Docker at all screen sizes.

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b one2code-update-step-img-icon-id.png-#4400 gh-pages
git pull https://github.com/one2code/website.git update-step-img-icon-id.png-#4400

@graycodesnu graycodesnu self-assigned this Apr 17, 2023
@graycodesnu
Copy link
Member

ETA: EOD 4/17
Availability: 10 AM - 12 PM, 4/17

@roslynwythe roslynwythe self-requested a review April 17, 2023 22:03
@roslynwythe
Copy link
Member

Availability: 8 - 10 pm
ETA: EOD 4/17

Copy link
Member

@graycodesnu graycodesnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @one2code! Great job working this issue. The branches were set up correctly and the correct change was made. You also stated the reason this change was made and provided the necessary info in your pull request. Thank you!

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Getting Started https://www.hackforla.org/getting-started Feature: Refactor HTML size: 0.25pt Can be done in 0.5 to 1.5 hours labels Apr 18, 2023
Copy link
Member

@roslynwythe roslynwythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @one2code. The branches are setup properly, the code change is correct and checks out in the browser and you provided an explanation of your work. Thank you!

@roslynwythe roslynwythe merged commit f0a47ce into hackforla:gh-pages Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Refactor HTML good first issue Good for newcomers P-Feature: Getting Started https://www.hackforla.org/getting-started role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

img Tag Refactor: Getting Started page - step-img-icon id.png
3 participants